Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display data for specific countries in one command #14

Open
wants to merge 2 commits into
base: master
from

Conversation

@djuric
Copy link

djuric commented Mar 22, 2020

First of all thank you for this project, it's very useful and easy to use :)

I think this addition would be really nice, it's a way to display data for specific countries separated by '-'. For example:

corona italy-spain

or

corona us-uk-italy-spain

This way we can compare data from selected countries in the same table.

@ahmadawais

This comment has been minimized.

Copy link
Owner

ahmadawais commented Mar 22, 2020

Glad you like my work. This is a fantastic idea. Something I have been thinking about.

Some countries have - in their names. So maybe we should use a different separator. Let's say _? Thoughts?

@ahmadawais

This comment has been minimized.

Copy link
Owner

ahmadawais commented Mar 22, 2020

This fixes #15.

@djuric

This comment has been minimized.

Copy link
Author

djuric commented Mar 22, 2020

@ahmadawais you are right, it looks like there can be a country with - in the name. And & (which would be nice) will not work either because it's recognized as next command.

So yes, _ is a good candidate. I was also thinking about / but this looks a bit odd, it implies it's a directory path :)

utils/getCountries.js Outdated Show resolved Hide resolved
@ahmadawais ahmadawais added the 📦 NEW label Mar 24, 2020
@ahmadawais

This comment has been minimized.

Copy link
Owner

ahmadawais commented Mar 24, 2020

Thanks for the PR. Can you please update the PR in light of the latest release.

🔗 https://github.com/ahmadawais/corona-cli/releases/tag/3.4.0
🔗 https://www.npmjs.com/package/corona-cli

@ahmadawais ahmadawais force-pushed the ahmadawais:master branch from 1dbdc4e to 4bc3f58 Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.