📦 NEW: limit functionality to cli #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inukares
approved these changes
Mar 23, 2020
firasdib
commented
Mar 23, 2020
|
Definitely, we should only use absolute positive values.
… |
|
I suggest using something like
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/abs
Just turn the negative value to positive one.
… |
|
Thanks for the PR. Can you please update the PR in light of the latest release. 🔗 https://github.com/ahmadawais/corona-cli/releases/tag/3.4.0 |
|
Looks like some pretty major changes were made, and I'm not sure I'm the right person to fix this, even though I did the changes... |
|
I gave it a go. Have a look and see if you agree with the changes. |
|
Oh dang, again needs to be rebased. |
|
Rebased again.. |
|
No worries, I had rebased them on my end already. |
ahmadawais
changed the title
|
Thank you! 🔗 https://github.com/ahmadawais/corona-cli/releases/tag/3.6.0 I chose |
|
The help text is off: The alias is still displayed as |
|
Dang it. I thought I had removed it.
🔗 https://github.com/ahmadawais/corona-cli/releases/tag/3.8.4
🔗 https://www.npmjs.com/package/corona-cli
npm i -g corona-cli
… |
Inukares
pushed a commit
to Inukares/corona-cli
that referenced
this pull request
Mar 25, 2020
Co-authored-by: Firas Dib <firas@consid.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the feature described in #16