Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 NEW: limit functionality to cli #17

Merged
merged 1 commit into from Mar 25, 2020
Merged

Conversation

@firasdib
Copy link
Contributor

firasdib commented Mar 22, 2020

Implements the feature described in #16

@firasdib firasdib force-pushed the firasdib:master branch from 3665af6 to d9084f7 Mar 22, 2020
Copy link

viditvarshney left a comment

Good improvement

index.js Outdated Show resolved Hide resolved
@ahmadawais

This comment has been minimized.

Copy link
Owner

ahmadawais commented Mar 23, 2020

@ahmadawais

This comment has been minimized.

Copy link
Owner

ahmadawais commented Mar 23, 2020

@firasdib firasdib force-pushed the firasdib:master branch from d9084f7 to 23440d2 Mar 23, 2020
@ahmadawais

This comment has been minimized.

Copy link
Owner

ahmadawais commented Mar 24, 2020

Thanks for the PR. Can you please update the PR in light of the latest release.

🔗 https://github.com/ahmadawais/corona-cli/releases/tag/3.4.0
🔗 https://www.npmjs.com/package/corona-cli

@ahmadawais ahmadawais added the 📦 NEW label Mar 24, 2020
@firasdib

This comment has been minimized.

Copy link
Contributor Author

firasdib commented Mar 24, 2020

Looks like some pretty major changes were made, and I'm not sure I'm the right person to fix this, even though I did the changes...

@firasdib firasdib force-pushed the firasdib:master branch from 23440d2 to 106192e Mar 24, 2020
@firasdib

This comment has been minimized.

Copy link
Contributor Author

firasdib commented Mar 24, 2020

I gave it a go. Have a look and see if you agree with the changes.

@ahmadawais

This comment has been minimized.

Copy link
Owner

ahmadawais commented Mar 25, 2020

Oh dang, again needs to be rebased.

@firasdib firasdib force-pushed the firasdib:master branch from 106192e to a91faca Mar 25, 2020
@firasdib firasdib force-pushed the firasdib:master branch from a91faca to 8d9e3c6 Mar 25, 2020
@firasdib

This comment has been minimized.

Copy link
Contributor Author

firasdib commented Mar 25, 2020

Rebased again..

Copy link
Owner

ahmadawais left a comment

Looks good to me! ✔︎

@ahmadawais

This comment has been minimized.

Copy link
Owner

ahmadawais commented Mar 25, 2020

No worries, I had rebased them on my end already.

@ahmadawais ahmadawais changed the title Adds limit functionality to cli 📦 NEW: limit functionality to cli Mar 25, 2020
@ahmadawais ahmadawais merged commit 5b97523 into ahmadawais:master Mar 25, 2020
@ahmadawais

This comment has been minimized.

Copy link
Owner

ahmadawais commented Mar 25, 2020

@peschee

This comment has been minimized.

Copy link

peschee commented Mar 25, 2020

The help text is off:

   --limit, -n          Limit output to N entries

The alias is still displayed as -n, -l works.

@ahmadawais

This comment has been minimized.

Copy link
Owner

ahmadawais commented Mar 25, 2020

Inukares added a commit to Inukares/corona-cli that referenced this pull request Mar 25, 2020
Co-authored-by: Firas Dib <firas@consid.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.