Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up📦 NEW: limit functionality to cli #17
Conversation
viditvarshney left a comment
|
Good improvement |
This comment has been minimized.
This comment has been minimized.
|
Definitely, we should only use absolute positive values.
… |
This comment has been minimized.
This comment has been minimized.
|
I suggest using something like
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/abs
Just turn the negative value to positive one.
… |
This comment has been minimized.
This comment has been minimized.
|
Thanks for the PR. Can you please update the PR in light of the latest release.
|
This comment has been minimized.
This comment has been minimized.
|
Looks like some pretty major changes were made, and I'm not sure I'm the right person to fix this, even though I did the changes... |
This comment has been minimized.
This comment has been minimized.
|
I gave it a go. Have a look and see if you agree with the changes. |
This comment has been minimized.
This comment has been minimized.
|
Oh dang, again needs to be rebased. |
This comment has been minimized.
This comment has been minimized.
|
Rebased again.. |
|
Looks good to me! ✔︎ |
This comment has been minimized.
This comment has been minimized.
|
No worries, I had rebased them on my end already. |
This comment has been minimized.
This comment has been minimized.
|
Thank you!
I chose |
This comment has been minimized.
This comment has been minimized.
peschee
commented
Mar 25, 2020
|
The help text is off:
The alias is still displayed as |
This comment has been minimized.
This comment has been minimized.
|
Dang it. I thought I had removed it.
… |
Co-authored-by: Firas Dib <firas@consid.se>
firasdib commentedMar 22, 2020
Implements the feature described in #16