Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up📦 NEW: Add an option to sort data (#3) via @smitp #3
+45
−7
Conversation
|
Thanks for this. I was hoping to work on it later. Couple of questions and changes. Check comments. |
| `per-million` | ||
| ], | ||
| sortOrders: [ | ||
| 1, |
This comment has been minimized.
This comment has been minimized.
ahmadawais
Mar 20, 2020
Owner
I like the sort by death count that's set by default. Gives you the best picture. What do you say we make that default instead of sorting by countries?
This comment has been minimized.
This comment has been minimized.
smitp
Mar 20, 2020
Author
Contributor
It only sorts if sort option is provided. sortOrders are to specify asc/desc
I like the idea of sorting by cases today. That gives a better picture of situation than death count.
|
Check the comments. |
|
Looks good to me! ✔︎ |
ahmadawais
changed the title
This comment has been minimized.
This comment has been minimized.
|
Thank you, @smitp — I'm adding a couple more new features and releasing the new CLI in a few. |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
smitp commentedMar 20, 2020
•
edited by ahmadawais
...