Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摝 NEW: NonVerbose #41

Merged
merged 4 commits into from Mar 25, 2020
Merged

馃摝 NEW: NonVerbose #41

merged 4 commits into from Mar 25, 2020

Conversation

vzsky
Copy link
Contributor

@vzsky vzsky commented Mar 24, 2020

Solve issue #28
add options :
-b for borderless table -> look a lot cleaner
-q for quiet -> display no unrelated data, only the table

@ahmadawais
Copy link
Owner

Howdy, can you address the conflicts and also post a screenshot :)

index.js Outdated Show resolved Hide resolved
@vzsky
Copy link
Contributor Author

vzsky commented Mar 25, 2020

Screen Shot 2563-03-25 at 10 16 09

This is the screenshot of minimal mode

utils/cli.js Outdated
},
minimal: {
type: "boolean",
defualt: true,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default true is not the right thing here.

@@ -2,7 +2,8 @@ const welcome = require("cli-welcome");
const pkgJSON = require("./../package.json");
const updateNotifier = require("update-notifier");

module.exports = async () => {
module.exports = async (quiet) => {
if (quiet) return
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change it to quiet now?

@ahmadawais ahmadawais merged commit ae6f6fa into ahmadawais:master Mar 25, 2020
@ahmadawais
Copy link
Owner

Inukares pushed a commit to Inukares/corona-cli that referenced this pull request Mar 25, 2020
* 馃摝 NEW: NonVerbose

* 馃憣 IMPROVE: Rename option

Co-authored-by: Touch Sungkawichai <mb99n@Touchs-MacBook-Pro.local>
Co-authored-by: Ahmad Awais 鈿★笍 <me@AhmadAwais.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants