Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 NEW: NonVerbose #41

Merged
merged 4 commits into from Mar 25, 2020
Merged

📦 NEW: NonVerbose #41

merged 4 commits into from Mar 25, 2020

Conversation

@vzsky
Copy link
Contributor

vzsky commented Mar 24, 2020

Solve issue #28
add options :
-b for borderless table -> look a lot cleaner
-q for quiet -> display no unrelated data, only the table

@ahmadawais

This comment has been minimized.

Copy link
Owner

ahmadawais commented Mar 24, 2020

Howdy, can you address the conflicts and also post a screenshot :)

index.js Outdated Show resolved Hide resolved
utils/cli.js Show resolved Hide resolved
vzsky added 2 commits Mar 25, 2020
@vzsky

This comment has been minimized.

Copy link
Contributor Author

vzsky commented Mar 25, 2020

Screen Shot 2563-03-25 at 10 16 09

This is the screenshot of minimal mode
@ahmadawais ahmadawais force-pushed the ahmadawais:master branch from 1dbdc4e to 4bc3f58 Mar 25, 2020
},
minimal: {
type: "boolean",
defualt: true,

This comment has been minimized.

Copy link
@ahmadawais

ahmadawais Mar 25, 2020

Owner

Default true is not the right thing here.

@@ -2,7 +2,8 @@ const welcome = require("cli-welcome");
const pkgJSON = require("./../package.json");
const updateNotifier = require("update-notifier");

module.exports = async () => {
module.exports = async (quiet) => {
if (quiet) return

This comment has been minimized.

Copy link
@ahmadawais

ahmadawais Mar 25, 2020

Owner

Why change it to quiet now?

@ahmadawais ahmadawais merged commit ae6f6fa into ahmadawais:master Mar 25, 2020
Inukares added a commit to Inukares/corona-cli that referenced this pull request Mar 25, 2020
* 📦 NEW: NonVerbose

* 👌 IMPROVE: Rename option

Co-authored-by: Touch Sungkawichai <mb99n@Touchs-MacBook-Pro.local>
Co-authored-by: Ahmad Awais ⚡️ <me@AhmadAwais.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.