Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up📦 NEW: Add US States #6 via @bernardodsanderson #6
+73
−10
Conversation
This comment has been minimized.
This comment has been minimized.
|
I see it is working fine but sort is not working. |
ahmadawais
changed the title
This comment has been minimized.
This comment has been minimized.
|
Thank you @bernardodsanderson I refactored the code you wrote a lot, in case you want to check it out. Also added the sort feature set.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bernardodsanderson commentedMar 21, 2020
@ahmadawais - This PR adds states as a view option. I tried to follow your style but let me know if you'd like any changes or updates.