Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAQ] 馃憣 Shades of Purple VSCode Theme With No Italics #13

Closed
adi518 opened this issue Aug 24, 2018 · 7 comments
Closed

[FAQ] 馃憣 Shades of Purple VSCode Theme With No Italics #13

adi518 opened this issue Aug 24, 2018 · 7 comments

Comments

@adi518
Copy link

@adi518 adi518 commented Aug 24, 2018

No description provided.

@ahmadawais

This comment has been minimized.

Copy link
Owner

@ahmadawais ahmadawais commented Aug 24, 2018

No description?

@adi518

This comment has been minimized.

Copy link
Author

@adi518 adi518 commented Aug 24, 2018

Can you add a no italics version?

@ahmadawais ahmadawais self-assigned this Aug 27, 2018
@ahmadawais

This comment has been minimized.

Copy link
Owner

@ahmadawais ahmadawais commented Aug 27, 2018

The italics are very limited I am actually making an italic theme version on so many requests that I have received for it. What you can instead do is disable all the italics in the theme which I make a point to list together. Here 猬囷笍

https://github.com/ahmadawais/shades-of-purple-vscode/blob/master/themes/shades-of-purple-color-theme.json#L1099-L1119

OK on second thought, you can't do that. I thought one could do this with "workbench.colorCustomizations": { but that's not allowed.

Let me think about it.

@ahmadawais

This comment has been minimized.

Copy link
Owner

@ahmadawais ahmadawais commented Aug 27, 2018

OK, yes I figured it out. You can disable the italic scope by putting this in your settings.json file.

"editor.tokenColorCustomizations": {
		"textMateRules": [
			{
				"name": "[ITALICS] REMOVED",
				"scope": [
					"modifier",
					"this",
					"comment",
					"storage.modifier.js",
					"entity.other.attribute-name.js",
					"entity.other.attribute-name.html",
					"punctuation.definition.comment",
					"text.html.basic entity.other",
					"entity.other.attribute-name.tsx",
					"entity.other.attribute-name.jsx",
					"markup.quote.markdown meta.paragraph.markdown",
					"markup.italic.markdown",
					"text.jade entity.other.attribute-name.tag",
					"keyword.control.from.js",
					"entity.other.attribute-name.tag.pug"
				],
				"settings": {
					"fontStyle": ""
				}
			}
		]
	}

I have set fontStyle to an empty string. The reason is explained here 猬囷笍
Font style of the rule: 'italic', 'bold' or 'underline' or a combination. The empty string unsets inherited settings.

Peace! 鉁岋笍

@ahmadawais ahmadawais closed this Aug 27, 2018
@ahmadawais ahmadawais changed the title Feature request: No italics version 馃憣 Shades of Purple Vscode Theme With No Italics Aug 27, 2018
@ahmadawais ahmadawais changed the title 馃憣 Shades of Purple Vscode Theme With No Italics [FAQ] 馃憣 Shades of Purple Vscode Theme With No Italics Aug 27, 2018
@adi518

This comment has been minimized.

Copy link
Author

@adi518 adi518 commented Aug 27, 2018

I looked for settings I could override, but it appeared most of the snippets I found were out of date, since the settings API changed with time, heh. I'll try that.

@ahmadawais ahmadawais changed the title [FAQ] 馃憣 Shades of Purple Vscode Theme With No Italics [FAQ] 馃憣 Shades of Purple VSCode Theme With No Italics Aug 27, 2018
@adi518

This comment has been minimized.

Copy link
Author

@adi518 adi518 commented Aug 27, 2018

Oh, should be: ITALICS instead of ITALLICS. It's just a name, but still.

I think might be worth a PR. What do you think?

@ahmadawais

This comment has been minimized.

Copy link
Owner

@ahmadawais ahmadawais commented Aug 27, 2018

@adi518 It should work. I tested it. Also, name doesn't matter but yes, I just edited it. Would def be worth a PR. I have a bad habit of this typo. 馃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.