This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
Feedtag test #265
Merged
Feedtag test #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmdrz
approved these changes
Aug 9, 2019
| if err == nil { | ||
| *ft = newFT | ||
| *ft = *newFT |
There was a problem hiding this comment.
I have a question. What's the difference between *ft = *newFT and ft = newFT? Both of them are a pointer of FeedTag. So I think you don't need * for it.
There was a problem hiding this comment.
Yes both of them are pointer, they have the same type but we need *ft to update inner value of feedTag.
Please view attached playground https://play.golang.org/p/jVG7TjccB8W
|
Could you please fix the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi this PR: