New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with new WP widgets #1400

Closed
MARQAS opened this Issue Nov 11, 2017 · 15 comments

Comments

Projects
None yet
@MARQAS
Copy link
Collaborator

MARQAS commented Nov 11, 2017

They should get converted to respected AMP components

@ahmedkaludi

This comment has been minimized.

Copy link
Owner

ahmedkaludi commented Nov 11, 2017

@MARQAS new?

@ahmedkaludi ahmedkaludi added this to the 0.9.69 milestone Nov 11, 2017

@MohammedKaludi

This comment has been minimized.

Copy link
Collaborator

MohammedKaludi commented Nov 12, 2017

Yes these new widgets are coming from WP 4.9 version

@MARQAS

This comment has been minimized.

Copy link
Collaborator

MARQAS commented Nov 13, 2017

Yup, By new widgets I meant 4.9 widgets

@MohammedKaludi MohammedKaludi removed this from the 0.9.69 milestone Nov 20, 2017

@ahmedkaludi ahmedkaludi assigned santosh8793 and unassigned MARQAS Jul 4, 2018

@ahmedkaludi ahmedkaludi added this to the W15 milestone Jul 4, 2018

@santosh8793

This comment has been minimized.

Copy link
Collaborator

santosh8793 commented Jul 9, 2018

  1. Archive Widget - Title repeating twice and design is not proper.
  2. Audio Widget - Design is not proper.
  3. Calendar Widget - Design is not proper.
  4. Category Widget - Title repeating twice and design is not proper.
  5. Custom Html - Design is not proper.
  6. Gallery widget - Design is not proper.
  7. Image Widget - Design is not proper.
  8. Meta Widget - design is not proper.
  9. Navigation Menu - Design is not proper.
  10. Pages Widget - Design is not proper.
  11. Recent Comments - Design is not proper.
  12. Related Post - Design is not proper.

RajuJeelaga added a commit that referenced this issue Jul 13, 2018

#1400 Siwft Sidebar Default styling is done
#1400 Siwft Sidebar Default styling is done
@RajuJeelaga

This comment has been minimized.

Copy link
Collaborator

RajuJeelaga commented Jul 13, 2018

@santosh8793

  • Search - It is not showing

  • Category Dropdown option is not working.

  • When AMP Audio and video Widgets are added, it through a validation Error, Please make sure that no Validation will occur, when audio and video widgets are using.

@beingsmart3

This comment has been minimized.

Copy link
Collaborator

beingsmart3 commented Aug 17, 2018

Category Widget is not performing the action.

Ref: https://secure.helpscout.net/conversation/632971076/31371/

@MARQAS

This comment has been minimized.

Copy link
Collaborator

MARQAS commented Sep 20, 2018

AMP Audio and AMP video are throwing the errors of http which is fine

MARQAS added a commit that referenced this issue Sep 20, 2018

#1400 Widgets compatibility added and lots of improvement for Widgets…
… areas

All the issues related to Swift sidebar and Swift Footer widget area will also get resolved with this improvement in code.

MARQAS added a commit that referenced this issue Sep 20, 2018

@MARQAS

This comment has been minimized.

Copy link
Collaborator

MARQAS commented Sep 20, 2018

All the widgets should work fine now.
@RajuJeelaga can you give another glance at this?

@MARQAS MARQAS assigned MARQAS and RajuJeelaga and unassigned santosh8793 Sep 20, 2018

@Zabi09 Zabi09 modified the milestones: W15, Wave Dec 28, 2018

@pegazee

This comment has been minimized.

Copy link
Collaborator

pegazee commented Dec 31, 2018

AMP Audio and AMP video are throwing the errors of Invalid URL protocol 'http:' for attribute 'src'.
-> We can remove the https and http like in the forms to avoid the validation errors. @ajeetku and @MARQAS what do you say about this idea?

@pegazee

This comment has been minimized.

Copy link
Collaborator

pegazee commented Jan 3, 2019

I've tested these widgets in design 1,2,3 and swift theme. For archive and categories widgets, In D-1,2,3 getting "The tag 'FORM [method=GET]' requires including the 'amp-form' extension JavaScript" validation error. Screenshot > https://monosnap.com/file/5WNbXcisEiPGryymc3dZEPnueVG7Zb.

And for the swift theme, all widgets output are not in proper styling. Screenshot > https://monosnap.com/file/HaQSfzQ2lIJuCMclRA11B1LlQDsor9. As we can see in the D-1,2,3 styling are loading properly. Screenshot ( D-1 )> https://monosnap.com/file/IyLETXtVZLhllSQGIbAy7SojcbCYJe

MARQAS added a commit that referenced this issue Jan 3, 2019

@MARQAS

This comment has been minimized.

Copy link
Collaborator

MARQAS commented Jan 3, 2019

We are not adding any styles for sidebars, In design1 2 3, it is taking the default styles, but not in Swift.
Any solution for this @RajuJeelaga and @ahmedkaludi?

MARQAS added a commit that referenced this issue Jan 3, 2019

@pegazee

This comment has been minimized.

Copy link
Collaborator

pegazee commented Jan 4, 2019

** Review **

  • Kaleem

  • Imran

  • Talha

@beingsmart3 beingsmart3 removed their assignment Jan 4, 2019

@syedimran22 syedimran22 removed their assignment Jan 4, 2019

@ansaritalha ansaritalha removed their assignment Jan 5, 2019

RajuJeelaga added a commit that referenced this issue Jan 5, 2019

#1400 swift Above footer widget styling is done
#1400 swift Above footer widget styling is done and in the markup some changes are added

RajuJeelaga added a commit that referenced this issue Jan 5, 2019

#1400 Widget Above footer styling is done in Design 1,2 and 3
#1400 Widget Above footer styling is done in Design 1,2 and 3 on condition
@MohammedKaludi

This comment has been minimized.

Copy link
Collaborator

MohammedKaludi commented Jan 7, 2019

@MARQAS, once @RajuJeelaga completes his work. Please check the code and add escaping to the text domain (8bfc9c2#diff-6aa5512f7dd8d5ce60fc97b0f340912cR5390) and if it is ready then add it directly into Approval Pipe so we can push it immediately.

RajuJeelaga added a commit that referenced this issue Jan 7, 2019

#1400 Widget styling improvement is done in swift
#1400 Widget styling improvement is done in swift

MARQAS added a commit that referenced this issue Jan 7, 2019

MARQAS added a commit that referenced this issue Jan 7, 2019

RajuJeelaga added a commit that referenced this issue Jan 7, 2019

#1400 widget styling is done properly in design 1,2 and 3
#1400 widget styling is done properly in design 1,2 and 3

RajuJeelaga added a commit that referenced this issue Jan 7, 2019

#1400 widget Search icon is added with css in Design 1,2 and 3
#1400 widget Search icon is added with css in Design 1,2 and 3

MARQAS added a commit that referenced this issue Jan 8, 2019

MARQAS added a commit that referenced this issue Jan 8, 2019

MARQAS added a commit that referenced this issue Jan 8, 2019

MARQAS added a commit that referenced this issue Jan 8, 2019

MARQAS added a commit that referenced this issue Jan 8, 2019

MARQAS added a commit that referenced this issue Jan 8, 2019

@MohammedKaludi

This comment has been minimized.

Copy link
Collaborator

MohammedKaludi commented Jan 9, 2019

merged and will be pushed in 0.9.97.24

@HANEEFRIYAZ

This comment has been minimized.

Copy link
Collaborator

HANEEFRIYAZ commented Jan 10, 2019

pushed in 0.9.97.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment