New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom post type is showing a blank page in the swift theme #2512

Closed
beingsmart3 opened this Issue Sep 7, 2018 · 6 comments

Comments

Projects
None yet
@beingsmart3
Copy link
Collaborator

beingsmart3 commented Sep 7, 2018

Custom post type is showing a blank page in the swift theme but it displays all posts in other designs

Issue recreated on localhost

Ref: https://secure.helpscout.net/conversation/656585818/33407?folderId=1914712

@Zabi09 Zabi09 added the bug label Sep 10, 2018

@Zabi09 Zabi09 self-assigned this Sep 10, 2018

@Zabi09 Zabi09 added this to the W15 milestone Sep 10, 2018

@Zabi09 Zabi09 removed their assignment Sep 24, 2018

MARQAS added a commit that referenced this issue Sep 29, 2018

RajuJeelaga added a commit that referenced this issue Sep 29, 2018

MARQAS added a commit that referenced this issue Sep 29, 2018

@merajali294

This comment has been minimized.

Copy link
Collaborator

merajali294 commented Oct 1, 2018

Fatal error: Uncaught Error: Call to undefined function ampforwp_get_all_post_types() in C:\xampp\htdocs\wordpress\wp-content\plugins\accelerated-mobile-pages-0.9.98\accelerated-moblie-pages.php:217

MARQAS added a commit that referenced this issue Oct 3, 2018

@mlt0882

This comment has been minimized.

Copy link

mlt0882 commented Oct 18, 2018

So if we wanted our custom posts to be blank (I have a custom plug-in that basically strips away the theme to a blank page to do landing pages), would I just undo the code added into #2512?

Not super well-versed in PHP but that looks like it is merging the Swift theme post style that we select with our custom post style, so it seems like that would make sense. Please advise.

@MARQAS

This comment has been minimized.

Copy link
Collaborator

MARQAS commented Nov 5, 2018

@mlt0882, I am unable to understand what you want to achieve, can you please elaborate your issue more?
Do you want to keep the Custom Post Types blank?

@pegazee

This comment has been minimized.

Copy link
Collaborator

pegazee commented Dec 31, 2018

** Review **

  • Kaleem

  • Imran

  • Talha

@beingsmart3 beingsmart3 removed their assignment Jan 2, 2019

@syedimran22 syedimran22 removed their assignment Jan 2, 2019

@ansaritalha ansaritalha removed their assignment Jan 2, 2019

@MohammedKaludi

This comment has been minimized.

Copy link
Collaborator

MohammedKaludi commented Jan 4, 2019

👍 can be merged into master

Zabi09 added a commit that referenced this issue Jan 5, 2019

@HANEEFRIYAZ

This comment has been minimized.

Copy link
Collaborator

HANEEFRIYAZ commented Jan 10, 2019

Pushed in 0.9.97.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment