New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

" Top " Button functionality to be improved. #2529

Closed
merajali294 opened this Issue Sep 14, 2018 · 8 comments

Comments

Projects
None yet
9 participants
@merajali294
Copy link
Collaborator

merajali294 commented Sep 14, 2018

Reference: https://secure.helpscout.net/conversation/662249094/34121?folderId=2090438

A user request is to make the Top Button appear when we do a little scroll, down towards the right side of the screen.

@Zabi09 Zabi09 added the feature label Sep 15, 2018

@Zabi09 Zabi09 added this to the W15 milestone Sep 15, 2018

@ahmedkaludi

This comment has been minimized.

RajuJeelaga added a commit that referenced this issue Oct 8, 2018

#2529 Bottom to top scroll option styling is improved in swift
#2529 Bottom to top scroll option styling is improved in swift

RajuJeelaga added a commit that referenced this issue Oct 9, 2018

#2529 Styling improvement is done in Design 1,2 and 3
#2529 Styling improvement is done in Design 1,2 and 3
@RajuJeelaga

This comment has been minimized.

Copy link
Collaborator

RajuJeelaga commented Oct 9, 2018

RajuJeelaga added a commit that referenced this issue Oct 10, 2018

#2529 bottom to top scroll functionality is properly styled in design…
… 1,2,3 and swift

#2529 bottom to top scroll functionality is properly styled in design
1,2,3 and swift

RajuJeelaga added a commit that referenced this issue Oct 24, 2018

#2529 Design 3 amp_back_to_top_link code is replace with old code to …
…get animation effect.

#2529 Design 3 amp_back_to_top_link code is replace with old code to get
animation effect.

RajuJeelaga added a commit that referenced this issue Oct 24, 2018

#2529 Desing 3 styling is done for back to top link
#2529 Desing 3 styling is done for back to top link

RajuJeelaga added a commit that referenced this issue Oct 25, 2018

#2529 condition is added for the animation scripts.
#2529 condition is added for the animation scripts.
@beingsmart3

This comment has been minimized.

Copy link
Collaborator

beingsmart3 commented Nov 17, 2018

when Back to Top link option is disabled it still loading The extension 'amp-animation' was found on this page but is unused. the same issue occurring in Newspaper theme.
the issue was occurring in Beta and gets fixed

Ref: https://secure.helpscout.net/conversation/701865618/39607?folderId=1914712

@ahmedkaludi ahmedkaludi modified the milestones: W15, Wave 2 Nov 19, 2018

@MARQAS

This comment has been minimized.

Copy link
Collaborator

MARQAS commented Nov 23, 2018

@beingsmart3 please add the latest beta and check, it has been resolved

@ahmedkaludi ahmedkaludi modified the milestones: Wave 2, W15 Nov 27, 2018

@Zabi09 Zabi09 modified the milestones: W15, Wave Dec 28, 2018

@ajeetku

This comment has been minimized.

Copy link
Collaborator

ajeetku commented Dec 31, 2018

  • Add escaping while finalizing this ticket After "ampforwp_translation" function
@Zabi09

This comment has been minimized.

Copy link
Collaborator

Zabi09 commented Jan 2, 2019

when Back to Top link option is disabled it still loading The extension 'amp-animation' was found on this page but is unused. the same issue occurring in Newspaper theme.
the issue was occurring in Beta and gets fixed

Ref: https://secure.helpscout.net/conversation/701865618/39607?folderId=1914712

This error is still appearing in latest version

@MohammedKaludi

This comment has been minimized.

Copy link
Collaborator

MohammedKaludi commented Jan 2, 2019

Styling is not good. @RajuJeelaga need improvements.

Zabi09 added a commit that referenced this issue Jan 4, 2019

RajuJeelaga added a commit that referenced this issue Jan 5, 2019

#2529 bottom to top scroll button styling is improved and translater …
…text is removed

#2529  bottom to top scroll button styling is improved and translater text is removed

RajuJeelaga added a commit that referenced this issue Jan 8, 2019

#2529 sticky social icon is enable bottom to top scroll css is added …
…on condition

#2529 When sticky social icon is enable bottom to top scroll css is added on condition...

RajuJeelaga added a commit that referenced this issue Jan 8, 2019

#2529 sticky social icon is enable, bottom to top scroll css is added…
… …in Design1,2,3

#2529 sticky social icon is enable, bottom to top scroll css is added …in Design1,2,3

Zabi09 added a commit that referenced this issue Jan 8, 2019

@HANEEFRIYAZ

This comment has been minimized.

Copy link
Collaborator

HANEEFRIYAZ commented Jan 10, 2019

Pushed in 0.9.97.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment