New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whenever Responsive AD is enabled then the AD should load on the screen without any effect to the normal mode AD in D1,2,3, and Swift #2531

Closed
merajali294 opened this Issue Sep 14, 2018 · 10 comments

Comments

Projects
None yet
9 participants

@Zabi09 Zabi09 self-assigned this Sep 15, 2018

@Zabi09 Zabi09 added the bug label Sep 15, 2018

@Zabi09 Zabi09 added this to the W15 milestone Sep 15, 2018

@merajali294 merajali294 changed the title Need to update styling code conditions in D1,2,3, and Swift Whenever Responsive AD is enabled then the AD should load on the screen without any effect to the normal mode AD in D1,2,3, and Swift Sep 17, 2018

Zabi09 added a commit that referenced this issue Sep 18, 2018

@MohammedKaludi

This comment has been minimized.

Copy link
Collaborator

MohammedKaludi commented Sep 24, 2018

Conditions not added properly, if responsive is enabled on 1st advert then styling is added to all of the ads, this is not correct.

All the controls should be properly connected.

Zabi09 added a commit that referenced this issue Oct 11, 2018

@MohammedKaludi

This comment has been minimized.

Copy link
Collaborator

MohammedKaludi commented Dec 21, 2018

👍 moving the ticket to testing department.

@pegazee

This comment has been minimized.

Copy link
Collaborator

pegazee commented Dec 31, 2018

** Review **

  • kaleem

  • talha

  • Imran

@syedimran22

This comment has been minimized.

Copy link
Collaborator

syedimran22 commented Jan 2, 2019

Sitewide ads are not loading in homepage in beta whereas in master it is rendering perfectly.

@beingsmart3 : when enabling below the footer ads option the ads are loading in both above & below the footer.

@beingsmart3 beingsmart3 removed their assignment Jan 2, 2019

@pegazee

This comment has been minimized.

Copy link
Collaborator

pegazee commented Jan 2, 2019

Regarding the Sitewide ads on Homepage, It's working on my end and I've checked on all designs ( D- 1,2,3 and swift ). @syedimran22 please check once on your end or else consult me.

And regarding the "Below the Footer" ads, Yes it's loading above the footer and below the footer which is not correct. @ajeetku please check it once.

@ajeetku

This comment has been minimized.

Copy link
Collaborator

ajeetku commented Jan 2, 2019

@pegazee I checked this issue is not related to this ticket, please create a new ticket for it.

@pegazee

This comment has been minimized.

Copy link
Collaborator

pegazee commented Jan 2, 2019

Sure

@pegazee

This comment has been minimized.

Copy link
Collaborator

pegazee commented Jan 2, 2019

I've created the ticket #2778

@syedimran22 syedimran22 removed their assignment Jan 3, 2019

@ansaritalha ansaritalha removed their assignment Jan 3, 2019

@MohammedKaludi

This comment has been minimized.

Copy link
Collaborator

MohammedKaludi commented Jan 4, 2019

👍 can be merged into master

Zabi09 added a commit that referenced this issue Jan 4, 2019

@HANEEFRIYAZ

This comment has been minimized.

Copy link
Collaborator

HANEEFRIYAZ commented Jan 10, 2019

Pushed in 0.9.97.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment