New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Hide AMP Option is enabled in PageEditor with Convert AMP to WP theme (Beta) enabled it's providing output as AMP Page #2735

Closed
merajali294 opened this Issue Dec 12, 2018 · 3 comments

Comments

Projects
None yet
10 participants
@merajali294
Copy link
Collaborator

merajali294 commented Dec 12, 2018

Reference:
https://secure.helpscout.net/conversation/690864360/38119/

If we enable Hide AMP Option with AMP takeover enabled it's hiding the AMP Version.
But if same done by keeping Convert AMP to WP theme (Beta) enabled it's displaying the AMP Version instead of hiding the AMP.

@ahmedkaludi ahmedkaludi added this to the Wave milestone Dec 12, 2018

@MARQAS MARQAS self-assigned this Dec 12, 2018

MARQAS added a commit that referenced this issue Dec 12, 2018

@Zabi09 Zabi09 added the bug label Dec 13, 2018

@pegazee

This comment has been minimized.

Copy link
Collaborator

pegazee commented Dec 22, 2018

** Review **

  • Kaleem

  • Imran

  • Talha

@syedimran22 syedimran22 removed their assignment Dec 22, 2018

@beingsmart3 beingsmart3 removed their assignment Dec 26, 2018

@ansaritalha ansaritalha removed their assignment Dec 28, 2018

@MohammedKaludi

This comment has been minimized.

Copy link
Collaborator

MohammedKaludi commented Jan 2, 2019

👍 ready, @Zabi09 go ahead and merge it immediately

Zabi09 added a commit that referenced this issue Jan 2, 2019

@HANEEFRIYAZ

This comment has been minimized.

Copy link
Collaborator

HANEEFRIYAZ commented Jan 10, 2019

Pushed in 0.9.97.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment