New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add amp endpoint filter #2761

Closed
ajeetku opened this Issue Dec 20, 2018 · 3 comments

Comments

Projects
None yet
8 participants
@ajeetku
Copy link
Collaborator

ajeetku commented Dec 20, 2018

Need to add amp endpoint filter "ampforwp_is_amp_endpoint"

@ajeetku

This comment has been minimized.

Copy link
Collaborator

ajeetku commented Dec 20, 2018

  • File: accelerated-moblie-pages.php
    Line 488 in BETA
    Inside this function "ampforwp_is_amp_endpoint" need to add filter before return in else part
    return apply_filters('ampforwp_is_amp_endpoint', false !== get_query_var( 'amp', false ) );

  • File "Feaures.php" In "ampforwp_url_controller" Function
    before return need to add a filter return esc_url( apply_filters( 'ampforwp_url_controller', $new_url ) );

@ahmedkaludi ahmedkaludi added this to the Wave milestone Dec 21, 2018

@Zabi09 Zabi09 added the feature label Dec 26, 2018

Zabi09 added a commit that referenced this issue Dec 26, 2018

@pegazee

This comment has been minimized.

Copy link
Collaborator

pegazee commented Jan 3, 2019

** Review **

  • kaleem

  • Imran

  • Talha

@HANEEFRIYAZ

This comment has been minimized.

Copy link
Collaborator

HANEEFRIYAZ commented Jan 10, 2019

Pushed in 0.9.97.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment