New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Convert AMP to WP theme (Beta) is enabled GDPR popup isn't closing #2763

Closed
merajali294 opened this Issue Dec 22, 2018 · 5 comments

Comments

Projects
None yet
10 participants

@ahmedkaludi ahmedkaludi added this to the Wave milestone Dec 24, 2018

@Zabi09 Zabi09 added the bug label Dec 26, 2018

@Zabi09 Zabi09 self-assigned this Dec 27, 2018

Zabi09 added a commit that referenced this issue Dec 27, 2018

@MohammedKaludi

This comment has been minimized.

Copy link
Collaborator

MohammedKaludi commented Dec 27, 2018

Zabi09 added a commit that referenced this issue Dec 28, 2018

@ajeetku

This comment has been minimized.

Copy link
Collaborator

ajeetku commented Dec 31, 2018

Remove this console.log(); while finalize this ticket

function ampforwp_gdpr(){console.log();

Zabi09 added a commit that referenced this issue Dec 31, 2018

@pegazee

This comment has been minimized.

Copy link
Collaborator

pegazee commented Dec 31, 2018

-> Zabi just committed the code and removed the console.log();
-> Moving this ticket to next pipeline.

@pegazee

This comment has been minimized.

Copy link
Collaborator

pegazee commented Dec 31, 2018

** Review **

  • Kaleem

  • Imran

  • Talha

@ansaritalha ansaritalha removed their assignment Jan 2, 2019

@beingsmart3 beingsmart3 removed their assignment Jan 2, 2019

@syedimran22 syedimran22 removed their assignment Jan 2, 2019

Zabi09 added a commit that referenced this issue Jan 5, 2019

@HANEEFRIYAZ

This comment has been minimized.

Copy link
Collaborator

HANEEFRIYAZ commented Jan 10, 2019

Pushed in 0.9.97.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment