Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block theme 404 #773

Open
vontainment opened this issue Nov 19, 2022 · 4 comments
Open

Block theme 404 #773

vontainment opened this issue Nov 19, 2022 · 4 comments

Comments

@vontainment
Copy link

vontainment commented Nov 19, 2022

In the PWA file with the setting for 404 page set to default it is set as the homepage. This causes a block theme with a 404 template to show the homepage instead. I think the default setting for the 404 page should be set to nothing so the 404 template will work.

@vontainment
Copy link
Author

vontainment commented Nov 19, 2022

After testing a bit more. It looks like the PWA is caching the homepage / and serving it as 404. The first 404 error works right, the rest don't but if I control shift refresh to bypass cache it works.

@radiogyan
Copy link

Any update on this? I am still facing this issue. Thanks.

@vontainment
Copy link
Author

once a 404 page is reached the rest are forwarded to home page and so are 410 so this plugin destroys SEO. even if set to netwrok only it still caches / as the 404 page and treats 410 as 404

@vontainment
Copy link
Author

is there a way we can turn off the 404 caching adding something to function.php?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants