Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support checkstyle report output #108. Support for the -r and -f para… #110

Merged
merged 12 commits into from Jul 12, 2016

Conversation

@ngeor
Copy link
Contributor

ngeor commented May 27, 2015

…meters of scss-lint.

This enables to set in options

format: 'Checkstyle',
require: 'scss_lint_reporter_checkstyle'

The names are in compliance with the CLI tool:

Usage: scss-lint [options] [scss-files]
    -f, --format Formatter           Specify how to display lints
    -r, --require path               Require Ruby file

As a side-effect, with my fix you can use all built-in formatters of scss-lint (Config, Files, JSON, XML) as long as you use the reporterOutput option of grunt-scss-lint.

@mariusbuescher

This comment has been minimized.

Copy link

mariusbuescher commented Jul 10, 2015

Try setting the mocha_istanbul.options.timeout configuration in Gruntfile.js to a higher value, e.g. 2500. It seems other developers struggle with similar problems.

@ngeor

This comment has been minimized.

Copy link
Contributor Author

ngeor commented Jan 30, 2016

AppVeyor fails, Travis passes. If I go to AppVeyor history for this project, I can't really find any build that was successful. Is it possible that it is misconfigured?

@ngeor

This comment has been minimized.

Copy link
Contributor Author

ngeor commented May 15, 2016

I've updated the PR. It passes on Travis. On AppVeyor things are more difficult. I had to tell mocha-istanbul to hide the output of mocha + istanbul. AppVeyor gets confused and treats that output as an error. But even with this, AppVeyor dies at the final command, regarding code climate. That one however in the documentation says it only works for the master branch.

In the PR I've done some further changes:

  • I've updated all gem and node dependencies to the latest, as the master is quite old.
  • I've set AppVeyor to run also for node 4.4 (Travis picks up the latest anyway)
  • Unit tests are written in various styles and most of them are integration tests anyway. I grouped them based on the technique that is being used.

At this point, I can't really proceed any further unless @ahmednuaman has a look at the PR and my findings regarding AppVeyor.

Also, I bumped up the version from 0.3.8 to 0.4.0 but perhaps it is worth bumping it up to 1.0.0 since all dependencies are upgraded.

@ahmednuaman

This comment has been minimized.

Copy link
Owner

ahmednuaman commented Jul 5, 2016

Let me remove this appveyor nonsense.

@ahmednuaman

This comment has been minimized.

Copy link
Owner

ahmednuaman commented Jul 5, 2016

Can you squash the commits please and hopefully that'll kick off the tests again.

@ngeor

This comment has been minimized.

Copy link
Contributor Author

ngeor commented Jul 5, 2016

Hm I don't see travis picking it up. I even added a dummy commit in .gitignore

@ngeor

This comment has been minimized.

Copy link
Contributor Author

ngeor commented Jul 5, 2016

Actually it works: https://travis-ci.org/ahmednuaman/grunt-scss-lint/builds/142527737 I don't know why it's not displayed inline in the PR in GitHub

@ahmednuaman

This comment has been minimized.

Copy link
Owner

ahmednuaman commented Jul 6, 2016

Can you rebase please?

ngeor added 9 commits May 27, 2015
…meters of scss-lint.

Updating Gemfile to include scss_lint_reporter_checkstyle as dependency.
…. Removing obsolete jscs rule. Adding more recent nodejs environments for appveyor. Upgraded gem dependencies.
… Fixing colorizing output. Fixing assertion regarding errors.
Adding no-exit mocha option.
Making sure there's no output in the console.
@ngeor

This comment has been minimized.

Copy link
Contributor Author

ngeor commented Jul 7, 2016

Of course, should be fine now! Here's the latest build: https://travis-ci.org/ahmednuaman/grunt-scss-lint/builds/142999385

scss_lint (0.40.1)
rainbow (~> 2.0)
sass (~> 3.4.1)
rake (11.1.2)

This comment has been minimized.

Copy link
@ahmednuaman

ahmednuaman Jul 8, 2016

Owner

Why rake?

This comment has been minimized.

Copy link
@ngeor

ngeor Jul 8, 2016

Author Contributor

It gets added when I run 'bundle'. Could be because of the upgrade I did on the Gemfile?

This comment has been minimized.

Copy link
@ahmednuaman

ahmednuaman Jul 10, 2016

Owner

I'm not sure if it's needed cos rake tasks aren't used here.

@ngeor

This comment has been minimized.

Copy link
Contributor Author

ngeor commented Jul 10, 2016

I took out the 'rake' dependency from Gemfile.lock . Latest build: https://travis-ci.org/ahmednuaman/grunt-scss-lint/builds/143670110

It fails with message: "Your Gemfile.lock is corrupt. The following gem is missing from the DEPENDENCIES
section: 'rake'"

@ngeor

This comment has been minimized.

Copy link
Contributor Author

ngeor commented Jul 10, 2016

I also removed the 'rake' nested dependency underneath scss-lint, same result. Like I said initially, I have not added the 'rake' dependency myself. In Gemfile, it is not present. This is apparently a dependency of scss-lint and it gets written into the generated file Gemfile.lock once one runs 'bundle'.

@ahmednuaman ahmednuaman merged commit 2c41c7d into ahmednuaman:master Jul 12, 2016
@ngeor

This comment has been minimized.

Copy link
Contributor Author

ngeor commented Jul 12, 2016

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.