Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more cli tests for kubens #117

Merged
merged 4 commits into from Jan 3, 2019

Conversation

@doodlesbykumbi
Copy link
Contributor

commented Jan 3, 2019

No description provided.

@ahmetb

This comment has been minimized.

Copy link
Owner

commented Jan 3, 2019

I think you pushed to the branch of #116 so I can't merge that now.

@doodlesbykumbi

This comment has been minimized.

Copy link
Contributor Author

commented Jan 3, 2019

@ahmetb i closed #116 and deleted the branch then created a brand new branch with all the changes. you should be good to merge from here. 1 PR to rule them all :)

@doodlesbykumbi doodlesbykumbi force-pushed the doodlesbykumbi:tests/kubens branch from 3d30fbc to ea81c77 Jan 3, 2019

kubens Outdated Show resolved Hide resolved
kubens Outdated Show resolved Hide resolved
kubens Outdated Show resolved Hide resolved
mock-kubectl Outdated Show resolved Hide resolved
mock-kubectl Outdated Show resolved Hide resolved
mock-kubectl Outdated Show resolved Hide resolved
test/common.bash Outdated Show resolved Hide resolved
test/kubens.bats Outdated Show resolved Hide resolved
@doodlesbykumbi

This comment has been minimized.

Copy link
Contributor Author

commented Jan 3, 2019

@ahmetb addressed your comments and replied where it made sense to do so

@doodlesbykumbi doodlesbykumbi force-pushed the doodlesbykumbi:tests/kubens branch from 3b3d383 to 1145b9e Jan 3, 2019

test/kubens.bats Show resolved Hide resolved
test/kubens.bats Outdated Show resolved Hide resolved
test/mock-kubectl Outdated Show resolved Hide resolved
kubens Outdated Show resolved Hide resolved
test/kubens.bats Outdated Show resolved Hide resolved
test/docker/Dockerfile Outdated Show resolved Hide resolved

@doodlesbykumbi doodlesbykumbi force-pushed the doodlesbykumbi:tests/kubens branch from 4d3704c to f7a193c Jan 3, 2019

@ahmetb

ahmetb approved these changes Jan 3, 2019

@ahmetb

This comment has been minimized.

Copy link
Owner

commented Jan 3, 2019

Thanks these are looking good now! 🙏

@ahmetb ahmetb merged commit 402cc2c into ahmetb:master Jan 3, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@doodlesbykumbi doodlesbykumbi deleted the doodlesbykumbi:tests/kubens branch Jan 3, 2019

ahmetb added a commit that referenced this pull request Jan 28, 2019

v0.6.3
- FIX: Show current context/ns color in interactive (fzf) mode. (#109)
- TEST: Add integration tests for kubectx (#111, #113) and kubens (#105, #117)

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.