Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectx rename check if old_name is a valid ctx #139

Merged
merged 1 commit into from Apr 4, 2019

Conversation

@ahmetb
Copy link
Owner

commented Apr 3, 2019

Without this safeguard, when user runs kubectx NEW_NAME=OLD_NAME where
NEW_NAME is an existing context but OLD_NAME isn't, we end up deleting NEW_NAME
and not doing any renames (because OLD_NAME is not found).

Fixes #136.

kubectx rename check if old_name is a valid ctx
Without this safeguard, when user runs `kubectx NEW_NAME=OLD_NAME` where
NEW_NAME is an existing context but OLD_NAME isn't, we end up deleting NEW_NAME
and not doing any renames (because OLD_NAME is not found).

Fixes #136.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@RonaldFindling

This comment has been minimized.

Copy link

commented Apr 4, 2019

Looks fine for me --> local tryout throws the expected error and doesn't delete my old context :)

@ahmetb ahmetb merged commit b9614bd into master Apr 4, 2019

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.