Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Disable preview when fuzzy-finding #163
The user may have global settings that enable the preview pane in fzf.
Whatever the preview command is set as, it probably doesn't render
For kubectx, the context yaml itself would maybe be helpful, but it
This commit thus disables the preview, so that if the user did have it
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
Once you've signed (or fixed any issues), please reply here (e.g.
What to do if you already signed the CLA
@ahmetb No problem. This is a screenshot of
On the right hand side you can see the 'preview pane' that I have globally configured (via
I have no idea what percentage of users might have it configured, but it seems reasonably likely for any that use
The user may have global settings that enable the preview pane in fzf. Whatever the preview command is set as, it probably doesn't render anything meaningful for kubens - I can't think what would be. For kubectx, the context yaml itself would _maybe_ be helpful, but it likely contains secrets, so I don't personally think I'd find it useful enough to get into. This commit thus disables the preview, so that if the user did have it enabled, there's now no pane where there would previously have probably been an error, such as: [bat error]: '<namespace>': No such file or directory (os error 2)