Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing instruction for zsh on Linux #173

Merged
merged 2 commits into from Sep 9, 2019

Conversation

@easeev
Copy link
Contributor

commented Sep 6, 2019

@googlebot

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Sep 6, 2019

@easeev

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

@googlebot I signed it!

@googlebot

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Sep 6, 2019

@ahmetb

This comment has been minimized.

Copy link
Owner

commented Sep 6, 2019

You think it’s worth mentioning adding this command to zshrc?

@easeev

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

It looks suboptimal but that's the only way it works now. For some reason, $fpath way doesn't work.

@ahmetb ahmetb merged commit c3dd1e5 into ahmetb:master Sep 9, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.