Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add krew-release-bot support #189

Merged
merged 3 commits into from Jan 22, 2020
Merged

Add krew-release-bot support #189

merged 3 commits into from Jan 22, 2020

Conversation

@rajatjindal
Copy link
Contributor

rajatjindal commented Jan 19, 2020

Add krew-release-bot support

@googlebot googlebot added the cla: yes label Jan 19, 2020
@rajatjindal rajatjindal force-pushed the rajatjindal:release-bot branch from f062695 to 45c237e Jan 19, 2020
rajatjindal added 2 commits Jan 19, 2020
@rajatjindal rajatjindal force-pushed the rajatjindal:release-bot branch from 45c237e to e1c2f10 Jan 19, 2020
@ahmetb

This comment has been minimized.

Copy link
Owner

ahmetb commented Jan 19, 2020

I appreciate the work but can you only reduce this to krew release bot?

Sadly most github workflow steps you listed are buggy because of how bash works. Undefined variables, pipe errors, failed commands not terminating the shell etc.

I don’t have time to iterate on those so let’s just limit this to bot release.

- from: kubectx-*/kubectx
to: .
- from: kubectx-*/LICENSE
to: .

This comment has been minimized.

Copy link
@ahmetb

ahmetb Jan 19, 2020

Owner

Please instal .editorconfig to add newlines to files.
Otherwise the bot will not be able to auto-approve this due to diff here.

@rajatjindal rajatjindal force-pushed the rajatjindal:release-bot branch from e1c2f10 to d9d51e2 Jan 21, 2020
@rajatjindal

This comment has been minimized.

Copy link
Contributor Author

rajatjindal commented Jan 21, 2020

I've updated the PR as you suggested. thanks.

steps:
- name: Checkout
uses: actions/checkout@master
- name: Create Release

This comment has been minimized.

Copy link
@ahmetb

ahmetb Jan 21, 2020

Owner

I actually think you don’t need to create a release. Every tag is sort of implicitly is a release. And we don’t upload files etc. yet the download link would still work without a release.

What do you think? Would that work with the bot?

This comment has been minimized.

Copy link
@rajatjindal

rajatjindal Jan 22, 2020

Author Contributor

the bot at this moment expect release to be there. It also expected assets, which I removed while working on PR for kubectx.

I think we can relax not having release too. I will need to make changes to action/bot for that. and I will do that this weekend.

This comment has been minimized.

Copy link
@ahmetb

ahmetb Jan 22, 2020

Owner

I'm not really against creating a release, I guess it's ok to have this in this repo.

But I suspect many other bash-based repos will not bother creating releases. git tag && git push is good enough for many.

@ahmetb ahmetb merged commit f48c419 into ahmetb:master Jan 22, 2020
2 checks passed
2 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ahmetb

This comment has been minimized.

Copy link
Owner

ahmetb commented Jan 22, 2020

Hopefully next time we make a release I'll recall to see if this works. :)

on:
push:
tags:
- 'v*.*.*'

This comment has been minimized.

Copy link
@ahmetb

ahmetb Jan 22, 2020

Owner

please consider doing * here for other people's repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.