Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore errors from tput (to fix TERM=vt100) #73

Merged
merged 1 commit into from Aug 22, 2018

Conversation

@ahmetb
Copy link
Owner

commented Aug 22, 2018

Currently TERM=vt100 is causing kubectx failure since tput is returning
exitcode=1. vt100 does not have colors. Ignoring tput exit code.

Fixes #57.

ignore errors from tput (to fix TERM=vt100)
Currently TERM=vt100 is causing kubectx failure since tput is returning
exitcode=1. vt100 does not have colors. Ignoring tput exit code.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

@ahmetb ahmetb force-pushed the tput-fix branch from d2b7855 to 7640314 Aug 22, 2018

@ahmetb ahmetb merged commit 7b23263 into master Aug 22, 2018

@ahmetb ahmetb deleted the tput-fix branch Aug 22, 2018

ahmetb added a commit that referenced this pull request Aug 23, 2018
Release v0.6.0
- FEATURE: interactive search mode when kubectx and kubens are ran without any
  arguments and fzf(1) is detected in PATH. (#71, #74)
- FIX: kubectx -d now doesn't ignore arguments after the first argument. (#75)
- FIX: empty output bug when TERM=vt100 even though NO_COLOR is set. (#57, #73)
- FIX: --help exits with code 0 now. (#69, #72)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.