Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fzf toggle pr #82

Merged
merged 3 commits into from Aug 31, 2018

Conversation

@oliverisaac
Copy link
Contributor

commented Aug 29, 2018

I use FZF for other things but didn't want it enabled for this tool. This PR allows EU's to selectively disable FZF for both tools or just one tool.

@googlebot

This comment has been minimized.

Copy link
Collaborator

commented Aug 29, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
@oliverisaac

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2018

I signed it!

@googlebot

This comment has been minimized.

Copy link
Collaborator

commented Aug 29, 2018

CLAs look good, thanks!

@ahmetb

This comment has been minimized.

Copy link
Owner

commented Aug 29, 2018

ooh, this is exiciting!!!

I think we should just call it KUBECTX_IGNORE_FZF and use it in both kubens/kubectx (I don't see why people would disable it for one and keep it enabled for another). Can you make the change?

Also we should add to the readme something like:

If you have fzf installed, but want to opt out of using this feature, set the environment variable KUBECTX_IGNORE_FZF=1.

@oliverisaac

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2018

Done and done. I definitely agree with the env var name as NO_FZF felt a little to generic.

@ahmetb
ahmetb approved these changes Aug 29, 2018
Copy link
Owner

left a comment

Looks good, thanks. I'll re-review with a clearer mind –these long if statements occasionally cause bugs.

@ahmetb ahmetb added this to the v0.7.0 milestone Aug 31, 2018

@ahmetb

This comment has been minimized.

Copy link
Owner

commented Aug 31, 2018

Just tested manually, looks good thanks. It'll ship in the next release.

@ahmetb ahmetb merged commit ccc077b into ahmetb:master Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.