Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging all thrown exceptions #13

Closed
ahmetb opened this issue May 29, 2011 · 1 comment
Closed

Logging all thrown exceptions #13

ahmetb opened this issue May 29, 2011 · 1 comment
Assignees

Comments

@ahmetb
Copy link
Owner

ahmetb commented May 29, 2011

At some points we Log.error the exceptions we have thrown. However, should we log all of them, or not? This is an important design choice.

IMHO, to provide good maintainability, we should log all exceptions, because the client program may catch it, however it is already thrown by the framework and should appear in "framework logs".

There are about ~53 exceptions in the code thrown like :

throw new [...]

We should have something like this for all exceptions:

Exception e = new [...]
Log.err(e.getMessage());
throw e;

Let's discuss.

@ghost ghost assigned ahmetb May 29, 2011
@ahmetb
Copy link
Owner Author

ahmetb commented Jun 2, 2011

Fixed with commit 16a888f. Logging done when OrmanException#getMessage() called.

@ahmetb ahmetb closed this as completed Jun 2, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant