Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more support for Windows #48

Open
frankcarey opened this issue Jan 9, 2017 · 9 comments
Open

Add more support for Windows #48

frankcarey opened this issue Jan 9, 2017 · 9 comments

Comments

@frankcarey
Copy link
Contributor

@frankcarey frankcarey commented Jan 9, 2017

Right now, Windows should work but there are some things about it that are a pain.

To install for windows:

  • Download the windows-x64 build of ahoy.
  • Move the file to someplace like C:/Program Files/Ahoy/ and also rename it to ahoy.exe
  • Update your Path environment variable to include that directory e.g. C:\Program Files\Ahoy\
  • open a new cmd shell
  • Since you currently need bash, you have to install that on Windows 10 anniversary edition or greater OR install cygwin which seems to work well.

Instead, some might find it useful to use powershell or something else. If we allow the init script to be changed, then we should be able to allow people to customize it to use powershell instead... something like this?

echo {{cmd}} | powershell- Command -

So the tasks would be:

  • Support custom "entry/init" command
  • Add a Windows installer that does all the tasks above for you.
@frankcarey

This comment has been minimized.

Copy link
Contributor Author

@frankcarey frankcarey commented Jan 9, 2017

Wix looks useful as a cli tool to create windows installer backed MSI files.

See https://www.codeproject.com/Tips/105638/A-quick-introduction-Create-an-MSI-installer-with for a simple example.

@r15ch13

This comment has been minimized.

Copy link

@r15ch13 r15ch13 commented Jul 31, 2018

Ahoy has been added to Scoop (lukesampson/scoop@c30c092) and can be installed by running scoop install ahoy

@enzolutions

This comment has been minimized.

Copy link

@enzolutions enzolutions commented Aug 14, 2018

@r15ch13 I tried, the install works, but ahoy itself doesn't work after couple minutes of wait I have to cancel, works for you?

@r15ch13

This comment has been minimized.

Copy link

@r15ch13 r15ch13 commented Aug 16, 2018

This issue has to be fixed by ahoy. Calling ahoy.exe directly doesn't work either.

@frankcarey

This comment has been minimized.

Copy link
Contributor Author

@frankcarey frankcarey commented Jan 17, 2019

@enzolutions what happens when you call the windows version of ahoy? you say it just hangs?

@frankcarey

This comment has been minimized.

Copy link
Contributor Author

@frankcarey frankcarey commented Jan 17, 2019

Note that you can change the entrypoint if you don't have bash installed. See #64 (comment) for one example.

@enzolutions

This comment has been minimized.

Copy link

@enzolutions enzolutions commented Jan 17, 2019

@frankcarey just hangs, but I tested a long time ago, I will follow your recommendation as soon I have to test in windows again.

@frankcarey

This comment has been minimized.

Copy link
Contributor Author

@frankcarey frankcarey commented Jun 13, 2019

Note: this is still and issue! I'm working on it as we speak though.

@frankcarey

This comment has been minimized.

Copy link
Contributor Author

@frankcarey frankcarey commented Jun 13, 2019

OK, so it seemed to be a build issue for some reason (or perhaps I copied the wrong file).. I built it from source and it works fine. See ahoy-bin-windows-amd64.exe in the ahoy-2.0.0 release.

Note that I did have issues with some of our scripts when using cmd, but it seemed to work fine when using git-bash from when you install the git client in windows. Note: If one was to use the WSL (v1 or the upcoming v2) I would think the linux build would be the one you wanted to use though.

If others could test and confirm this is working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.