Skip to content

Commit 8da72a8

Browse files
committed
Experiment: fix lower_bounds fail on micrograd_demo by lower bounding base and core
1 parent 5409ca9 commit 8da72a8

File tree

4 files changed

+17
-12
lines changed

4 files changed

+17
-12
lines changed

arrayjit.opam

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ bug-reports: "https://github.com/lukstafi/ocannl/issues"
1515
depends: [
1616
"ocaml" {>= "5.2.0"}
1717
"dune" {>= "3.11"}
18-
"base"
19-
"core"
18+
"base" {>= "v0.17.0"}
19+
"core" {>= "v0.17.0"}
2020
"ctypes" {>= "0.23"}
2121
"ctypes-foreign" {>= "0.23"}
2222
"printbox"

dune-project

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,10 @@
5050
(ocaml
5151
(>= 5.2.0))
5252
dune
53-
base
54-
core
53+
(base
54+
(>= v0.17.0))
55+
(core
56+
(>= v0.17.0))
5557
(ctypes
5658
(>= 0.23))
5759
(ctypes-foreign
@@ -65,7 +67,8 @@
6567
ocannl_npy
6668
stdio
6769
num
68-
(saturn_lockfree (>= 0.5.0))
70+
(saturn_lockfree
71+
(>= 0.5.0))
6972
ppxlib
7073
ppx_jane
7174
ppx_expect
@@ -89,8 +92,10 @@
8992
(ocaml
9093
(>= 5.2.0))
9194
dune
92-
base
93-
core
95+
(base
96+
(>= v0.17.0))
97+
(core
98+
(>= v0.17.0))
9499
; opam 2.2.0 has with-dev-setup. Is it supported, what's the syntax?
95100
; (ocamlformat
96101
; (>= 0.26.2)

neural_nets_lib.opam

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ bug-reports: "https://github.com/lukstafi/ocannl/issues"
1515
depends: [
1616
"ocaml" {>= "5.2.0"}
1717
"dune" {>= "3.11"}
18-
"base"
19-
"core"
18+
"base" {>= "v0.17.0"}
19+
"core" {>= "v0.17.0"}
2020
"arrayjit"
2121
"printbox"
2222
"printbox-text"

test/micrograd_demo.ml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,9 @@ let%expect_test "Micrograd README basic example" =
8282
let%expect_test "Micrograd half-moons example" =
8383
Tensor.unsafe_reinitialize ();
8484
Rand.init 5;
85-
(* We could use the cc backend! But for unknown reason, it leads to different resuls on a
86-
lower_bounds CI target than on other CI targets. *)
87-
let module Backend = (val Arrayjit.Backends.fresh_backend ~backend_name:"sync_cc" ()) in
85+
(* Note: for as-yet unknown reason, this test can lead to different resuls on different versions
86+
of dependencies. *)
87+
let module Backend = (val Arrayjit.Backends.fresh_backend ~backend_name:"cc" ()) in
8888
let backend = (module Backend : Train.Backend_type with type context = Backend.context) in
8989
let device = Backend.(new_virtual_device @@ get_device ~ordinal:0) in
9090
let ctx = Backend.init device in

0 commit comments

Comments
 (0)