Skip to content

Conversation

@nv-tusharma
Copy link
Contributor

@nv-tusharma nv-tusharma commented Oct 28, 2025

Overview:

Add sglang ARM workflow to Github after completion of the wideep-sglang refactor. This PR uncomments the parts relevant to enable the sglang ARM workflow.

Details:

  • Uncomment ARM workflow for sglang in Github

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configuration to support multi-platform testing with improved parallel execution strategies.

Signed-off-by: Tushar Sharma <tusharma@nvidia.com>
@nv-tusharma nv-tusharma requested a review from a team as a code owner October 28, 2025 18:58
@github-actions github-actions bot added the ci Issues/PRs that reference CI build/test label Oct 28, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025

Walkthrough

The pull request modifies the GitHub Actions workflow configuration to enable matrix-based job execution for container validation. A strategy block is uncommented to support multi-platform testing across amd64 and arm64 architectures with distinct runner assignments, replacing the prior hard-coded runs-on setup.

Changes

Cohort / Cohort / File(s) Summary
GitHub Actions Workflow Configuration
.github/workflows/container-validation-backends.yml
Enables matrix strategy for sglang job with two platforms (amd64 with gpu-l40-amd64 runner, arm64 with cpu-arm-r8g-4xlarge runner), sets fail-fast to false, and updates job naming to include matrix.architecture variable.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Reviewable areas: Verify matrix platform definitions match intended runner requirements and that job naming convention updates correctly incorporate the architecture variable.

Poem

🐰 A workflow so fine, now runs on two kinds,
amd64 and arm64, working in tandem combined,
Matrix strategy, no hard coding in sight,
Container validation now scales left and right!

Pre-merge checks

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ⚠️ Warning The pull request description follows the template structure but lacks substantive content in most sections. While the Overview and Details sections contain some text describing the general intent to uncomment the ARM workflow for sglang, they provide minimal implementation detail. Critically, the "Where should the reviewer start?" section has no specific files called out, and the Related Issues section uses the template placeholder "closes GitHub issue: #xxx" without an actual issue number. The description does not guide reviewers on where to focus or link to related issue tracking, making it largely incomplete compared to the template requirements. The author should update the PR description to include specific files that reviewers should examine (e.g., .github/workflows/container-validation-backends.yml) in the "Where should the reviewer start?" section and provide an actual GitHub issue number in the Related Issues section. Additional details about what was uncommented (the matrix-based strategy, platform configurations) and why this change was made would also strengthen the description.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "ci: Enable github arm workflow for sglang" clearly describes the main change in the changeset, which is enabling matrix-based strategy support with ARM (arm64) platform configuration for the sglang job in the GitHub workflow file. The title is specific, concise, and directly reflects the primary objective of adding ARM workflow support. It avoids vague terminology and clearly communicates what was changed from a CI/infrastructure perspective.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Tushar Sharma <tusharma@nvidia.com>
@nv-tusharma nv-tusharma merged commit 927dcbf into main Oct 28, 2025
25 of 26 checks passed
@nv-tusharma nv-tusharma deleted the tusharma/add-sglang-arm-gha branch October 28, 2025 20:49
nv-tusharma added a commit that referenced this pull request Oct 28, 2025
Signed-off-by: Tushar Sharma <tusharma@nvidia.com>
nv-tusharma added a commit that referenced this pull request Oct 28, 2025
Signed-off-by: Tushar Sharma <tusharma@nvidia.com>
csabakecskemeti pushed a commit to csabakecskemeti/dynamo that referenced this pull request Oct 31, 2025
Signed-off-by: Tushar Sharma <tusharma@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Issues/PRs that reference CI build/test size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants