Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using RuboCop? #164

Closed
utkarsh2102 opened this issue Jun 23, 2020 · 4 comments
Closed

Using RuboCop? #164

utkarsh2102 opened this issue Jun 23, 2020 · 4 comments

Comments

@utkarsh2102
Copy link
Contributor

utkarsh2102 commented Jun 23, 2020 •
edited

Hi @ai,

Thanks for working on and maintaining this amazing library! 馃殌
However, since we maintain this in Debian and if I run rubocop on the source tree, I get a lot of offenses. Therefore, I'd ask, would you be open to using RuboCop?I'll be happy to raise a PR if so? 馃槃
@ai
Copy link
Owner

ai commented Jun 23, 2020

Yeap, let's try

@utkarsh2102
Copy link
Contributor Author

Perfect, I'll get around to doing it by this weekend!

Thank you very much! 馃敟馃挴

@utkarsh2102 utkarsh2102 mentioned this issue Jul 30, 2020
Merged
@olleolleolle
Copy link
Contributor

@utkarsh2102 Can this be closed, now that #166 is merged?

@utkarsh2102
Copy link
Contributor Author

Absolutely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@olleolleolle @ai @utkarsh2102