Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rubocop #166

Merged
merged 2 commits into from Jul 30, 2020
Merged

Use rubocop #166

merged 2 commits into from Jul 30, 2020

Conversation

utkarsh2102
Copy link
Contributor

Hi @ai,

Thanks again for your awesome work in maintaining this! 馃敟

As discussed in #164, here's the first follow-up on this.
I'll do all the changes in 3 or 4 parts :)
(sorry for the delay, though!)

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
@ai
Copy link
Owner

ai commented Jul 30, 2020

Too late. I just deprecate the whole Autoprefixer Rails b01fef4

@utkarsh2102
Copy link
Contributor Author

Woops :/
However, given that there are so many gems using this already, we will keep maintaining this in Debian for a while, at least!

It'd still be nice if you could integrate these changes :)

@utkarsh2102
Copy link
Contributor Author

Well, in case you think it's not worth doing this anymore, I have one minor thing to change here - dropping the use of git ls-files in gemspec. This should really help us in maintaining. So I can instead shape this PR to do that instead?

Or in case you think, it's okay to use rubocop here, still, I can complete this whole thing.

Let me know what you think.

@ai
Copy link
Owner

ai commented Jul 30, 2020

Yeap, I will continue to accept security PRs.

I will accept Robocop PR a little later and I am open for gemspec PR too.

@utkarsh2102
Copy link
Contributor Author

Okay, that's very great of you!
Thanks for your work, really! Let me know when you think it's time for merging this. Once done, I'll open another follow-up PR for RuboCop fixes and lastly for gemspec!

Thanks again! 鉂わ笍

@ai ai merged commit 65a15f2 into ai:master Jul 30, 2020
@utkarsh2102 utkarsh2102 deleted the use-rubocop branch July 30, 2020 20:50
@olleolleolle olleolleolle mentioned this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants