Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining RuboCop issues #167

Merged
merged 3 commits into from Jul 31, 2020
Merged

Fix remaining RuboCop issues #167

merged 3 commits into from Jul 31, 2020

Conversation

utkarsh2102
Copy link
Contributor

@utkarsh2102 utkarsh2102 commented Jul 31, 2020 •
edited

Hi @ai,

This is a follow-up of #166 馃殌
Each commit represents a different subset of change so it'd be best to not squash those commits! 馃槃

Thanks! 鉂わ笍

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>

@utkarsh2102
Fix Layout/SpaceInsideHashLiteralBraces issues
dd6868a 
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
@utkarsh2102
Fix Layout/ArgumentAlignment issues
f7821de 
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
@utkarsh2102
Fix other minor RuboCop issues
62626d3 
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
@utkarsh2102 utkarsh2102 changed the title Fix remaining rubocop issues Fix remaining RuboCop issues Jul 31, 2020
@ai
Copy link
Owner

ai commented Jul 31, 2020

it'd be best to not merge those commits

Do you mean that this PR is still in progress? You can convert it to Draft in GitHub.

@utkarsh2102
Copy link
Contributor Author

I meant squashing, apologies! This is ready, I just did this in separate commits.
(so it'd be best if you're okay with not squashing?)

@utkarsh2102
Copy link
Contributor Author

utkarsh2102 commented Jul 31, 2020 •
edited

Each commit represents a different subset of change so it'd be best to not merge those commits!

merge ---> squash 馃槄
Edited the description.

@ai ai merged commit 56a9fdc into ai:master Jul 31, 2020
@ai
Copy link
Owner

ai commented Jul 31, 2020

Great work. Thanks 馃憤

@utkarsh2102 utkarsh2102 deleted the fix-remaining-rubocop-issues branch July 31, 2020 04:05
@utkarsh2102
Copy link
Contributor Author

Thank you! 鉂わ笍
Just last two bits are remaining now, I'll get to them at the earliest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@utkarsh2102 @ai