Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop git ls-files in gemspec #170

Merged
merged 1 commit into from Aug 1, 2020
Merged

Drop git ls-files in gemspec #170

merged 1 commit into from Aug 1, 2020

Conversation

utkarsh2102
Copy link
Contributor

Hi @ai,

This is the last one from my end, finally! 馃槄
It drops the usage of git in gemspec. Thereby helping us to maintain this more easily in Debian! 馃殌

Really thanks for your support so far, you're the best! 鉂わ笍

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>

@utkarsh2102
Copy link
Contributor Author

Whaat, this is weird. CI's failing weirdly after running the tests successfully! 馃
Okay, I'ma convert this into draft PR, and ping you once it is ready!

@utkarsh2102 utkarsh2102 marked this pull request as draft July 31, 2020 21:18
@utkarsh2102 utkarsh2102 force-pushed the drop-git branch 4 times, most recently from 0aacd88 to ed95f47 Compare July 31, 2020 21:30
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
@utkarsh2102
Copy link
Contributor Author

Okay, green and clean build with commits squashed! 馃帀

@utkarsh2102 utkarsh2102 marked this pull request as ready for review July 31, 2020 21:52
@ai ai merged commit e769e12 into ai:master Aug 1, 2020
@utkarsh2102 utkarsh2102 deleted the drop-git branch August 1, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants