Esbuild plugin

[Toomean]

Hello there! I've worked on a plugin for esbuild( according to #267 ).
Not sure about the needed requirements and the final point for this

Take a look, please

[ai]

Looks excellent. We just need also check.import support to test libraries with tree-shaking.

Search for check.import and import in the project and you will find a code in webpack plugin (and config validation in size-limit) which you will need to back port (copy-pasting is OK, but if it will be possible to move some helpers to size-limit and then re-use it, it will better).

[ai]

We will need tests with empty project to validate these constants.

The project with empty file should have 0 bytes.

The project with one digit export (and import config) should have 1 byte size.

[Toomean]

I'm struggling with this a bit. Could you help me with that? Maybe we have an example of how to validate such kinds of constants

[ai]

Here is a test example for *_EMPTY_PROJECT_IMPORT and *_EMPTY_PROJECT_IMPORT_GZIP
https://github.com/ai/size-limit/blob/main/packages/webpack/test/index.test.js#L241-L268

Here is a test example for *_EMPTY_PROJECT and *_EMPTY_PROJECT_GZIP (yeap, it is in size-limit and not in webpack plugin for historical reason, feel free to move).
https://github.com/ai/size-limit/blob/main/packages/size-limit/test/run.test.js#L322-L328

[ai]

We still need to fix coverage and fix some strange Node.js 12 issue

[ai]

Test coverage shows that we need to calibrate (test) ESBUILD_EMPTY_PROJECT_IMPORT and ESBUILD_EMPTY_PROJECT_IMPORT_GZIP.

Also, we still have Node.js 12 problem:

> error: Could not resolve "/home/runner/work/size-limit/size-limit/packages/esbuild/test/fixtures/unknown.js"

 > error: Refusing to overwrite input file "../../../../../tmp/size-limit-qzG5j_Arw23-2HlwpuSXJ/index.js" (use "allowOverwrite: true" to allow this)

 > error: Refusing to overwrite input file "../../../../../tmp/size-limit-8Rz_8m1YKc_k-mX_IJzsY/index.js" (use "allowOverwrite: true" to allow this)

[Toomean]

Can't reproduce errors from actions on my local machine, will investigate it on another os. As I see, this problem appears on every node version

[ai]

Can't reproduce errors from actions on my local machine

It could be related to CI environment also

[ai]

I pushed merge commit to run CI

[ai]

Greta work. Thanks.