Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: drop Node v < 10 | Move from ava to jest #2

Merged
merged 5 commits into from Mar 20, 2020

Conversation

@JPeer264
Copy link
Contributor

JPeer264 commented Mar 19, 2020

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 19, 2020

Coverage Status

Coverage decreased (-2.5%) to 83.636% when pulling cbeb819 on JPeer264:chore/update-appveyor into 8165265 on aichbauer:master.

@JPeer264

This comment has been minimized.

Copy link
Contributor Author

JPeer264 commented Mar 19, 2020

We should drop Node v4 and v6 and support only Node v10 and v12. Then appveyor should go green

@aichbauer

This comment has been minimized.

Copy link
Owner

aichbauer commented Mar 19, 2020

That sounds right. Don't forget to change the node versions for the travis build as well.

@JPeer264 JPeer264 changed the title Chore: update appveyor Chore: update appveyor, travis. Drop Node v < 10 Mar 20, 2020
@JPeer264 JPeer264 changed the title Chore: update appveyor, travis. Drop Node v < 10 Chore: drop Node v < 10 | Move from ava to jest Mar 20, 2020
@JPeer264

This comment has been minimized.

Copy link
Contributor Author

JPeer264 commented Mar 20, 2020

@aichbauer appveyor works now with jest, but the coverage is just more strict than before (imports are not included in the coverage), that's why coveralls is now dropping 2.5%

@aichbauer

This comment has been minimized.

Copy link
Owner

aichbauer commented Mar 20, 2020

No problem.

Send from GitHub Android App 😱

Copy link
Owner

aichbauer left a comment

LGTM

Send from GitHub Webapp 🥶

@aichbauer aichbauer merged commit 1586327 into aichbauer:master Mar 20, 2020
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-2.5%) to 83.636%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JPeer264 JPeer264 deleted the JPeer264:chore/update-appveyor branch Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.