New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard cmake way of defining package version #151

Merged
merged 2 commits into from May 7, 2017

Conversation

Projects
None yet
2 participants
@andresailer
Member

andresailer commented May 5, 2017

These changes simplify the setting of the package version, so that the version only has to be defined in one place. This allows more automatic tagging of dd4hep, which needs to have the PACKAGE_VERSION_* variables be set in the main CMakeLists file.

Also change the variables in DDSegmentation to cmake like PACKAGE_VERSION_* (Will adapt tagging scripts to modify this file automatically as well and change ddsegmentation version via tagging script when making the tag on Monday...)

BEGINRELEASENOTES

  • Use cmake to create Version.h file to contain DD4hep version information and macros
  • Change the way DD4hep package version is defined and set standard cmake variables for this purpose

ENDRELEASENOTES

@andresailer andresailer force-pushed the andresailer:cmakeStuff branch from 439c85b to 3ae40a2 May 5, 2017

@andresailer andresailer requested a review from MarkusFrankATcernch May 5, 2017

@andresailer andresailer referenced this pull request May 5, 2017

Merged

Tagging4 dd4hep #26

@MarkusFrankATcernch

This comment has been minimized.

Contributor

MarkusFrankATcernch commented May 5, 2017

I believe this is OK like this. The only question, which came to my mind was:
Does DDSegmentation really need it's own versioning?
In principle we anyhow at some point wanted to merge it into DD4hep.

@andresailer

This comment has been minimized.

Member

andresailer commented May 5, 2017

No ddsegmentation doesn't need its own version. But changing the package structure was too much to do until Monday.

@andresailer andresailer merged commit 12c9317 into AIDASoft:master May 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@andresailer andresailer deleted the andresailer:cmakeStuff branch Aug 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment