New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix id position conv #157

Merged
merged 2 commits into from Jun 7, 2017

Conversation

Projects
None yet
3 participants
@gaede
Contributor

gaede commented Jun 2, 2017

BEGINRELEASENOTES

  • bug fix in test_cellid_position_converter
    • with this no tests for position from cellID lookup should fail
  • re-implement CellIDPositionConverter::cellID(pos)

ENDRELEASENOTES

gaede added some commits Jun 2, 2017

reimplement CellIDPositionConverter::cellID(pos)
 - new implementation based on TGeoManager::FindNode()
 - slightly reduces errors wrt to previous implmentation
// return result ;
// }

This comment has been minimized.

@petricm

petricm Jun 2, 2017

Member

Can you please remove the old code not just comment out

This comment has been minimized.

@gaede

gaede Jun 7, 2017

Contributor

Actually, I would like to keep the commented out code in, as this is an alternative way of computing the cellID from the position (and we might want to come back to this later ...)

This comment has been minimized.

@andresailer

andresailer Jun 7, 2017

Member

Use the history for these kind of things.

@gaede gaede merged commit b58853b into AIDASoft:master Jun 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment