New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in VolumeManager returning bad top level subdetectors #248

Merged
merged 6 commits into from Oct 17, 2017

Conversation

Projects
None yet
3 participants
@MarkusFrankATcernch
Contributor

MarkusFrankATcernch commented Oct 17, 2017

BEGINRELEASENOTES

VolumeManager Implementation

A possibly important bug was fixed for the lookup of top level subdetectors in the VolumeManager by volume identifers of (sensitive) volumes. Due to a bug in the de-masking possible wrong top level subdetectors were returned. The default use cases typically do not use this call and hence should not be affected.

ENDRELEASENOTES

@MarkusFrankATcernch MarkusFrankATcernch merged commit 766e146 into AIDASoft:master Oct 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@petricm petricm added the bug label Oct 17, 2017

@gaede

This comment has been minimized.

Contributor

gaede commented Oct 18, 2017

@MarkusFrankATcernch Hi Markus, how important is this bug fix ? Which calls are (possibly) affected ? We are about to make a large software release and I would like to stay with the last release tag of DD4hep for this - if possible ...
Cheers, Frank.

@petricm

This comment has been minimized.

Member

petricm commented Oct 19, 2017

Based on a discussion in the developers meeting, this bug has limited implications, since the function (lookupDetector(VolumeID volume_id)) that has the bug is not called anywhere in DD4hep apart from one test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment