New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDG4/python/DDG4.py: Changed failure condition for loadDDG4() #254

Merged
merged 1 commit into from Nov 1, 2017

Conversation

Projects
None yet
2 participants
@decibelcooper
Member

decibelcooper commented Oct 30, 2017

Since gSystem.Load() can return 1 if the library has already been
loaded, there are cases where requiring result == 0 raises a false
exception. This commit changes the required condition to be result >= 0

This PR resolves #253

BEGINRELEASENOTES

  • DDG4/python/DDG4.py: loadDDG4() changed to not raise exception if libraries are already loaded

ENDRELEASENOTES

DDG4/python/DDG4.py: Changed failure condition for loadDDG4()
Since gSystem.load() can return 1 if the library has already been
loaded, there are cases where requiring `result == 0` raises a false
exception.  This commit changes the required condition to be `result >=
0`

@andresailer andresailer merged commit ddbe5a9 into AIDASoft:master Nov 1, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@decibelcooper decibelcooper deleted the decibelcooper:loadDDG4 branch Nov 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment