New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend functionallity of the Mask from DDDetectors #434

Merged
merged 1 commit into from Aug 20, 2018

Conversation

Projects
None yet
3 participants
@oviazlo

oviazlo commented Aug 14, 2018

BEGINRELEASENOTES

  • DD4hep_Mask_o1_v01_geo
    • allow rotation around x-axis (instead of y)
    • phi1 and phi2 cone angles configurable from the xml-file

ENDRELEASENOTES

extend functionallity of the Mask in DDDetectors: allow rotation arou…
…nd x-axis, make phi1 and phi2 rotation angles configurable from xml-file
@oviazlo

This comment has been minimized.

oviazlo commented Aug 14, 2018

Changes to be confirmed by @AMKolano

@petricm petricm added the enhancement label Aug 15, 2018

@AMKolano

This comment has been minimized.

AMKolano commented Aug 20, 2018

It is working fine. Thank you, Anna

@petricm petricm changed the title from [WIP] extend functionallity of the Mask from DDDetectors to Extend functionallity of the Mask from DDDetectors Aug 20, 2018

@petricm petricm merged commit 4e8e4e2 into AIDASoft:master Aug 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment