New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple fixes for nested detectors, DDCMS, xml utilities #442

Merged
merged 5 commits into from Oct 15, 2018

Conversation

Projects
None yet
2 participants
@MarkusFrankATcernch
Contributor

MarkusFrankATcernch commented Oct 15, 2018

BEGINRELEASENOTES

  • DDCMS: Update to support namespaces
  • DDUpgrade test example for the LHCb upgrade
  • Fix nested detectors (in fact worked only for first level parents)
  • Add VolumeBuilder XML utility to work on XML-tree patterns
    ENDRELEASENOTES

@MarkusFrankATcernch MarkusFrankATcernch merged commit 658aa6a into AIDASoft:master Oct 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@petricm

This comment has been minimized.

Member

petricm commented Oct 15, 2018

Sorry but I don't think this is a good idea you just dumped 70MB of data to the repo in examples/DDUpgrade/data/. Files LHCb.gdml 22MB and LHCb.gdml.orig 18MB don't really belong into the repo.

A clone of DD4hep is now 180 MB, whereas before this it was 100 MB which is also not small. A proposal could be that we put such files on the DD4hep webpage and then CMake curls them down when it's called?

On this topic, I did not realize we had a 30MB file in the history:

size SHA location
30511 cc3644720ecced0290d1086f685502e7438b0809 examples/CLICSiD/eve/CLICSiD_Events.root
21814 b8ad99d94209546709a01817ae719905cdb6366d examples/DDUpgrade/data/LHCb.gdml
17572 fe2abd109a3b51c0ff4ede42a457c53dabab59d3 examples/DDUpgrade/data/LHCb.gdml.orig
5237 cf9b1f92f2a63375aaa2a36edffd855edf79dc8f examples/CLICSiD/eve/CLICSiD_Events.slcio
4073 c97b87b1a582e8bb0065d059a561a266ca8f5ca1 examples/DDUpgrade/data/VP.gdml
2863 0c5a4bf85b1fc4217972cb96f2d193a2675e1e94 examples/DDG4/data/LHCb_MinBias_HepMC.txt
2863 9125b82ea601cf7b21a221269d8fbcec53750fca examples/DDDB/data/DDDB.tar.gz
2277 6a352296b57a5fface2f6ac578610b43776c3a25 examples/DDUpgrade/data/Muon.gdml
1688 1b1cfeb361a5792b1de9dff3597bff68670720bf examples/DDCodex/CodexB_2018-06-29_22-48.root
1585 dcd7518baaa8f9dbfe1ce5ed592d771c948ab58b examples/DDUpgrade/data/Rich1.gdml
@MarkusFrankATcernch

This comment has been minimized.

Contributor

MarkusFrankATcernch commented Oct 15, 2018

If you know how to do something like this in cmake, curl'ing is fine with me!

In principle the directory examples/DDUpgrade/data could be tar'ed and gzip'ed
if one would know how to expand them in cmake.
I did not know where to put the stuff and a safe base, hence I though git is appropriate....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment