New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDDetector: Fix overlaps #258

Merged
merged 3 commits into from Nov 16, 2017

Conversation

Projects
None yet
2 participants
@decibelcooper
Member

decibelcooper commented Nov 6, 2017

This PR resolves #257

BEGINRELEASENOTES

  • Corrected EcalBarrel constructor after finding significant layer overlaps
  • Corrected CylindricalEndcapCalorimeter factors of 2 in layer/slice thickness
  • Corrected ForwardDetector factors of 2 in layer/slice thickness

ENDRELEASENOTES

@decibelcooper decibelcooper changed the title from [WIP] EcalBarrel: Fixed construction of EcalBarrel detector type to [WIP] EcalBarrel: Fix DDDetector overlaps Nov 6, 2017

@decibelcooper decibelcooper changed the title from [WIP] EcalBarrel: Fix DDDetector overlaps to [WIP] DDDetector: Fix overlaps Nov 6, 2017

@decibelcooper decibelcooper changed the title from [WIP] DDDetector: Fix overlaps to DDDetector: Fix overlaps Nov 6, 2017

@decibelcooper

This comment has been minimized.

Member

decibelcooper commented Nov 6, 2017

I have verified these changes by converting to GDML and performing overlap check and visual inspection with TGeoManager.

@andresailer

This comment has been minimized.

Member

andresailer commented Nov 7, 2017

Which detector model (XML files) did you use for the checks?
Also in the past we found that the geant4 overlap checker is more sensitive and reliable than the TGeo overlap checker, so maybe you could also run the geometry checker in geant4 (/geometry/test/run I think).

@decibelcooper

This comment has been minimized.

Member

decibelcooper commented Nov 7, 2017

@andresailer The compact files can be found here. It is a modified SiD description.

I am currently running a zero-tolerance check with /geometry/test/run. It will take a bit of time.

@decibelcooper

This comment has been minimized.

Member

decibelcooper commented Nov 7, 2017

I have confirmed that /geometry/test/run finds overlaps before this PR with the above compact files, and there are no overlaps with this PR.

@andresailer andresailer merged commit 23a3999 into AIDASoft:master Nov 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@decibelcooper decibelcooper deleted the decibelcooper:overlap_fixes branch May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment