New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic for ignoring warnings in dictionary creation #277

Merged
merged 2 commits into from Dec 5, 2017

Conversation

Projects
None yet
1 participant
@petricm
Member

petricm commented Dec 4, 2017

BEGINRELEASENOTES

  • Fix logic for ignoring warnings in dictionary creation
  • Add -Wno-overlength-strings to all generated targets

ENDRELEASENOTES

When using clang the value for __clang__ is 1 and the value for __GNUC__ is 4, whereas in the GCC case __clang__ is not defined and __GNUC__ is the main compiler version, thus the logic has to be swapped. But since clang accepts #pragma GCC diagnostic ignored this does really change much.

@petricm petricm added the bug fix label Dec 4, 2017

@petricm petricm force-pushed the petricm:master branch from 1f923ba to cbb4de0 Dec 5, 2017

Fix logic for ignoring warnings in dictionary creation and exclude ov…
…erlength strings warnings form generated targets

@petricm petricm force-pushed the petricm:master branch from cbb4de0 to 98c02cc Dec 5, 2017

@petricm petricm merged commit 78dd87c into AIDASoft:master Dec 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment