New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for ExtraParticles and ParticleHandler #315

Merged
merged 4 commits into from Feb 16, 2018

Conversation

Projects
None yet
2 participants
@andresailer
Member

andresailer commented Feb 15, 2018

BEGINRELEASENOTES

  • DDG4::ExtraParticles: particles with too small life time were tagged as stable, now correctly marked unstable
  • DDG4::Geant4InputHandling: pass all particles except strings, quarks and gluons to Geant4 to get completely consistent MCParticle History, fixes #307
  • DDG4::Geant4PrimaryHandler: add property RejectPDGs
  • DDG4::Geant4InputHandling: print geant4 primary particle chains if VERBOSE

ENDRELEASENOTES

I tried to figure something more generic than a fixed list of pdgIDs to ignore, but the G4ParticleDefinition::IsShortLived also returns true for rho0 for example, so this cannot be used to find particles to ignore either. Quarks could be identified by their non-integer charge, but that doesn't work for gluons.

TODO:

  • Make the set of pdgIDs to ignore configurable at run time

@andresailer andresailer changed the title from [WIP] Fixes for ExtraParticles and ParticleHandler to Fixes for ExtraParticles and ParticleHandler Feb 16, 2018

@petricm petricm added the enhancement label Feb 16, 2018

@andresailer andresailer force-pushed the andresailer:histoFixNew branch from 1488c39 to 225c4c6 Feb 16, 2018

@petricm petricm merged commit 0d8ae71 into AIDASoft:master Feb 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@andresailer andresailer deleted the andresailer:histoFixNew branch Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment