New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing LCIO input parameters to output #321

Merged
merged 7 commits into from Mar 1, 2018

Conversation

Projects
None yet
3 participants
@rete
Contributor

rete commented Feb 27, 2018

Resolves #309
BEGINRELEASENOTES

  • Geant4InputAction and Geant4EventReader :
    • Register input action pointer to event reader, enabling the event reader to access the Geant4 context
  • Added new class LCIOEventParameters to handle LCIO input event parameters
  • LCIOFileReader :
    • Add extension with LCIO input event parameters to Geant4event
  • Geant4Output2LCIO :
    • Get LCIO event parameters from event extension (if any) and write them to LCIO output event

ENDRELEASENOTES

/// Get the context (from the input action)
Geant4Context* Geant4EventReader::context() const {
if( 0 == m_inputAction ) {
printout(FATAL,"Geant4EventReader: %s", "No input action registered!");

This comment has been minimized.

@andresailer

andresailer Feb 27, 2018

Member

the "%s" has to be removed, second argument is the "name for the printout"
From the failed test (https://travis-ci.org/AIDASoft/DD4hep/jobs/346807978#L1623)

Geant4EventReader: ���҂� FATAL No input action registered!

@rete rete changed the title from Passing LCIO input parameters to output to [WIP] Passing LCIO input parameters to output Feb 28, 2018

Geant4Output2LCIO: Use event and run number offset also in the case o…
…f presence of input event parameters extension

@rete rete changed the title from [WIP] Passing LCIO input parameters to output to Passing LCIO input parameters to output Feb 28, 2018

@rete

This comment has been minimized.

Contributor

rete commented Feb 28, 2018

Can be merged on my side, if approved.

@petricm petricm merged commit f093041 into AIDASoft:master Mar 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment