New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphicalMaterialScan: add electric and magnetic fields scans #333

Merged
merged 2 commits into from Mar 13, 2018

Conversation

Projects
None yet
3 participants
@danieljeans
Contributor

danieljeans commented Mar 8, 2018

BEGINRELEASENOTES

  • changed utility name from graphicalMaterialScan -> graphicalScan
  • add visualisation of electric and magnetic fields (switched by parameter)
  • change order of x/y/z range parameters for ease of use
  • added parameter for name of output root file
    ENDRELEASENOTES

@petricm petricm added the enhancement label Mar 8, 2018

@petricm

This comment has been minimized.

Member

petricm commented Mar 8, 2018

Thank you for this new addition, I am just wondering if putting it into graphicalMaterialScan is the right place, given that it visualizes the field. Or maybe we should rename this tool to graphicalScan to indicate it is doing more?

@danieljeans

This comment has been minimized.

Contributor

danieljeans commented Mar 9, 2018

I think it's rather natural to have it in the same package. It's just a few added lines of code, whereas if split into a separate utility, a lot of code duplication would be needed.
I am not against renaming this utility to graphicalScan (which I agree is more descriptive), but this may be disruptive to users. Is there some dd4hep policy in this regard?

@petricm

This comment has been minimized.

Member

petricm commented Mar 9, 2018

I would then suggest that you rename the tool to graphicalScan.
If you would be willing it would be appreciated if you could an option to do just the material scan or just the field scan if one does not want to 'waste' time with the other and default can be do both.

@danieljeans

This comment has been minimized.

Contributor

danieljeans commented Mar 13, 2018

renamed, and added requested feature to select type of scan (material or field).

@gaede gaede merged commit 41efa21 into AIDASoft:master Mar 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danieljeans danieljeans deleted the danieljeans:addfieldtoscan branch Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment