New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to reference pools in used slices #351

Merged
merged 8 commits into from Apr 5, 2018

Conversation

Projects
None yet
2 participants
@MarkusFrankATcernch
Contributor

MarkusFrankATcernch commented Apr 5, 2018

BEGINRELEASENOTES

  • To avoid unwanted disappearing conditions sub pools, a conditions slice may be instructed to collect shared references to the used pools in the slice.
  • For python:
    • Move DDG4/SystemOfUnits.py to DDG4/g4units.py
      Keep SystemOfUnits.py with deprecation warning
    • move DD4hep.py to dd4hep.py.
      import dd4hep also imports all TGeoUnit units into its namespace.
      Hence: import dd4hep; print dd4hep.m gives: "100.0"
    • DD4hep.py is kept for backwards compatibility issuing a deprecation warning
    • DDG4.py: imports g4units as G4Units: DDG4.G4Units.m etc.
    • DDG4.py: imports TGeoUnit as TGeo4Units: DDG4.TGeoUnits.m etc.
    • Some problem with replacing DD4hepUnits.h with TGeoSystemOfUnits.h
      Surface test complains. To be investigated. Keep old DD4hepUnits for the time being.
      ENDRELEASENOTES

@petricm petricm added the enhancement label Apr 5, 2018

@petricm petricm added the bug fix label Apr 5, 2018

@petricm

This comment has been minimized.

Member

petricm commented Apr 5, 2018

You could also include in addition to TGeoSystemOfUnits.h also TGeoPhysicalConstants.h it might be appreciated by some users.

@MarkusFrankATcernch MarkusFrankATcernch merged commit 5c48eb5 into AIDASoft:master Apr 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MarkusFrankATcernch

This comment has been minimized.

Contributor

MarkusFrankATcernch commented Apr 10, 2018

@petricm TGeoPhysicalConstants.h is not necessary to be included in the python interface.
These values are grouped together with TGeoSystemOfUnits in the namespace TGeoUnits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment