Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Power/Battery Modeling #10

Merged
merged 13 commits into from
Oct 20, 2022
Merged

Power/Battery Modeling #10

merged 13 commits into from
Oct 20, 2022

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Oct 11, 2022 •
edited
Loading

Description

Summary of changes

  • Added activities and power handling
  • Added sanity checks on actor creation
  • Added (dis)charging
  • Added to check for eclipse by central body
  • Added cfg parameter for simulation timestep
  • Added diagrams explaining paseos to readme
  • Reworked actor structure to have one local (the one paseos is running on) and known other actors

Resolved Issues

How Has This Been Tested?

Existing and new tests

Related Pull Requests

N/A

@gomezzz
- Added scaffolding for activities and power
2062d10 
- Added sanity checks on actor creation
- Added scaffold for (dis)charging
- Added to check for eclipse by central body
- Added cfg parameter for simulation timestep
@gomezzz gomezzz added the enhancement New feature or request label Oct 11, 2022
@gomezzz gomezzz self-assigned this Oct 11, 2022
@gomezzz gomezzz added feature implementing a new feature user-facing Anything that users can interact with documentation Improvements or additions to documentation labels Oct 18, 2022
@gomezzz gomezzz marked this pull request as ready for review October 18, 2022 11:50
This was referenced Oct 18, 2022
Closed
Closed
GabrieleMeoni
GabrieleMeoni requested changes Oct 19, 2022
View reviewed changes
paseos/actors/spacecraft_actor.py Show resolved Hide resolved
paseos/power/discharge_model.py Outdated Show resolved Hide resolved
paseos/actors/spacecraft_actor.py Show resolved Hide resolved
paseos/power/is_in_eclipse.py Show resolved Hide resolved
paseos/tests/init_test.py Show resolved Hide resolved
@gomezzz gomezzz merged commit 4048550 into main Oct 20, 2022
@gomezzz gomezzz deleted the Power/Battery-Modeling branch October 20, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrieleMeoni GabrieleMeoni GabrieleMeoni approved these changes

@johanos1 johanos1 Awaiting requested review from johanos1

Assignees

@gomezzz gomezzz

Labels
documentation Improvements or additions to documentation enhancement New feature or request feature implementing a new feature user-facing Anything that users can interact with
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Power/Battery Modeling
2 participants
@gomezzz @GabrieleMeoni