Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased allowed ranges for tests to allow passing tests on slower devices #158

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Mar 2, 2023

Description

Increased allow test ranges

Resolved Issues

How Has This Been Tested?

Ran CI locally and on github

Related Pull Requests

N/A

Copy link
Collaborator

@GabrieleMeoni GabrieleMeoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it. Can you, just, clarify how did you set the new values?

@gomezzz
Copy link
Collaborator Author

gomezzz commented Mar 2, 2023

I approve it. Can you, just, clarify how did you set the new values?

Basically the CI in the link issue took longer to complete the test which drew more power. So I made the tests pass even if it takes longer (and made the speedup a bit smaller). Might be it is still not enough, we will see.

@gomezzz gomezzz merged commit 3156aa9 into main Mar 3, 2023
@gomezzz gomezzz deleted the OS-X-CI-Bugs branch March 3, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failing on conda CI with OS X
2 participants