Visual implementation #27

johanos1 · 2022-10-23T19:31:31Z

Description

Summary of changes

A class to visualize the actors and central object in paseos

Resolved Issues

fixes #Issue

How Has This Been Tested?

Examples in visualization_example have been examined by human
Test added to paseos/tests without creating plot window. Makes sure the function calls are OK.

Related Pull Requests

#PR

gomezzz

A few comments, currently I can't run it yet on my machine because of imports etc.

paseos/actors/spacecraft_actor.py

paseos/paseos.py

paseos/visualization/animation.py

paseos/visualization/space_animation.py

gomezzz · 2022-10-24T16:09:35Z

I'd also suggest to merge main into this first given the changes from #26

…o visual_implementation

gomezzz · 2022-10-25T03:22:09Z

Ah, one more thought: Maybe we can add a minimal example of this to the README.md with a screenshot of what it looks like? This seems like the kind of feature user would really want to know how to use :)

gomezzz

a few more comments, in general I still think it would be nice to add a minimal example (like below) with a screenshot to the readme.md for users

I still can't run it outside the module with e.g.

import paseos
import pykep as pk
from paseos import SpacecraftActor,ActorBuilder
earth = pk.planet.jpl_lp('earth')
# Define local actor
sat1 = ActorBuilder.get_actor_scaffold(
    "sat1", SpacecraftActor, [10000000, 0, 0], pk.epoch(0)
)
ActorBuilder.set_orbit(sat1, [10000000, 0, 0], [0, 8000.0, 0], pk.epoch(0), earth)
ActorBuilder.set_power_devices(sat1, 500, 10000, 1)
# init simulation
sim = paseos.init_sim(sat1)

from paseos import SpaceAnimation
anim = SpaceAnimation(sim)
anim.animate(sim, "paseos_test", 200, 400)

I get [Errno 2] No such file or directory: '/home/pablo/ESA/PASEOS/my_notebooks/FontAwesome.otf' due the path not being relative (see here how to do it:

PASEOS/paseos/utils/load_default_cfg.py

Line 12 in 2f2d7c3

os.path.dirname(__file__) + "/../../resources/", "default_cfg.toml"

)

paseos/__init__.py

paseos/actors/spacecraft_actor.py

paseos/paseos.py

paseos/visualization/space_animation.py

paseos/visualization_test/test.py

gomezzz

Good news:

For me I get the exact same experience on Win & Linux
In both cases, in a jupyter notebook works

Bad news:

On my windows machine, if I run the example/visualization/example_animation.py I get this

On Linux it doesn't even open the window and just shows me briefly a blank screen window at the end.

But I have one more fundamental question, because I am starting to wonder how we interface this with the activities and user actions. Because then, you don't want to call something that blocks you from interacting with paseos?

It should be more like:

# Some setup code
# plot the current animation frame
paseos.plot()

# user can do some actions, activities whatever they want

# plot the next frame
paseos.plot( )

What do you think? @johanos1

gomezzz · 2022-10-31T10:06:19Z

paseos/power/is_in_eclipse.py

@@ -21,7 +21,7 @@ def is_in_eclipse(
    Returns:
        bool: True if actor is in eclipse
    """
-    logger.debug(f"Checking whether {actor} is in eclipse at {t}.")
+    logger.debug(f"Checking whether {actor} is in eclipse at {t.mjd2000/pk.SEC2DAY}.")


Please revert 🙏

paseos/visualization/space_animation.py

examples/visualization/example_jupyter.ipynb

gomezzz · 2022-11-01T14:14:11Z

let's highlight local actor in special color

- Fixed plotting on linux - Added single plot function - Added logging - Formatting

- Preparing NB for finalization

Visual implementation follow up

review-notebook-app · 2022-11-16T10:05:19Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

gomezzz

some minor changes

README.md

gomezzz · 2022-11-18T14:41:45Z

paseos/paseos.py

@@ -95,7 +95,6 @@ def add_known_actor(self, actor: BaseActor):
    @property
    def local_actor(self) -> BaseActor:
        """Returns the local actor.
-


Please revert these white space changes. There should be an empty line after description to follow https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html

gomezzz · 2022-11-18T14:42:14Z

paseos/power/is_in_eclipse.py

@@ -21,7 +21,7 @@ def is_in_eclipse(
    Returns:
        bool: True if actor is in eclipse
    """
-    logger.debug(f"Checking whether {actor} is in eclipse at {t}.")
+    logger.debug(f"Checking whether {actor} is in eclipse at {t.mjd2000/pk.SEC2DAY}.")


paseos/visualization/plot.py

gomezzz · 2022-11-18T14:45:28Z

We also need to explain somewhere what you actually see in the visualization. Especially what the blue ball is, what the green / red matrix is and why some actors have different colors. Probably in the readme? 🤔

gomezzz

👍 Only very minor string changes in readme I would still apply 🙏 We did it, yay! 🛰️ 🚀

README.md

Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>

johanos1 added 4 commits October 8, 2022 12:35

Changed name of init

e68c1ad

Merge branch 'main' of github.com:aidotse/PASEOS

5f04f97

Merge branch 'main' of github.com:aidotse/PASEOS

6fa1d00

First implementation of visualization for PASEOS

d99d84f

johanos1 requested review from gomezzz and GabrieleMeoni October 23, 2022 19:31

johanos1 added enhancement New feature or request feature implementing a new feature labels Oct 24, 2022

gomezzz requested changes Oct 24, 2022

View reviewed changes

gomezzz reviewed Oct 24, 2022

View reviewed changes

paseos/visualization/space_animation.py Show resolved Hide resolved

johanos1 added 9 commits October 24, 2022 20:17

First implementation of visualization for PASEOS

77668f2

Ability to save animation added

a33f978

First implementation of visualization for PASEOS

a2be401

Animation added to class

9edcdf1

First implementation of visualization for PASEOS

8f9f0b7

Fixed review comments

1e38513

Updated requirements

605e056

Tests included

4ff2201

Merge branch 'visual_implementation' of github.com:aidotse/PASEOS int…

1166add

…o visual_implementation

johanos1 requested a review from gomezzz October 25, 2022 10:58

gomezzz changed the base branch from main to extend_activities October 25, 2022 12:04

gomezzz changed the base branch from extend_activities to main October 25, 2022 12:04

gomezzz requested changes Oct 25, 2022

View reviewed changes

gomezzz mentioned this pull request Oct 26, 2022

Add a README #6

Closed

9 tasks

johanos1 added 4 commits October 27, 2022 11:21

Removed redundant properties in paseos + spacecraftactor

f4bafcd

Tests added and minimal examples.

8000098

Readme updated + communication plotted

352f1a5

Lint fixes

3c34f97

Flake8 :/

d7e1a4f

johanos1 requested a review from gomezzz October 30, 2022 11:41

gomezzz requested changes Oct 31, 2022

View reviewed changes

johanos1 and others added 6 commits November 6, 2022 15:28

Fine tuning to animation

4ec6b5e

WIP

ef75b2c

- Fixed plotting on linux - Added single plot function - Added logging - Formatting

Bugfixing and beautification

6feb866

- Some renaming, refactoring

9aec062

- Preparing NB for finalization

Removing duplicate code, flake fixes, getting rid of matplotlib warnings

ed2c532

applying comments from previous review

931d088

gomezzz mentioned this pull request Nov 14, 2022

Visual implementation follow up #39

Merged

gomezzz added 3 commits November 14, 2022 15:39

Merge branch 'main' into visual-implementation-follow-up

618fc42

readded try catch

ce2a85d

Merge pull request #39 from aidotse/visual-implementation-follow-up

538ddc7

Visual implementation follow up

gomezzz self-requested a review November 16, 2022 10:05

gomezzz and others added 2 commits November 16, 2022 11:38

Merge branch 'main' into visual_implementation

b724943

flaking

c72394f

gomezzz requested changes Nov 18, 2022

View reviewed changes

Readme update and small review comments

659668c

johanos1 requested a review from gomezzz November 21, 2022 14:28

gomezzz approved these changes Nov 21, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

johanos1 and others added 4 commits November 22, 2022 10:17

Update README.md

3e9e218

Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>

Update README.md

03d16fc

Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>

Update README.md

bba16cf

Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>

Update README.md

0bbfc19

Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>

johanos1 merged commit 4ea4fb2 into main Nov 22, 2022

gomezzz mentioned this pull request Nov 28, 2022

Create a visualization of the simulation #11

Closed

gomezzz deleted the visual_implementation branch December 1, 2022 10:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Visual implementation #27

Visual implementation #27

johanos1 commented Oct 23, 2022 •

edited

Loading

gomezzz left a comment

gomezzz commented Oct 24, 2022

gomezzz commented Oct 25, 2022

gomezzz left a comment

gomezzz left a comment

gomezzz Oct 31, 2022

gomezzz commented Nov 1, 2022

review-notebook-app bot commented Nov 16, 2022

gomezzz left a comment

gomezzz Nov 18, 2022

gomezzz Nov 18, 2022

gomezzz commented Nov 18, 2022

gomezzz left a comment

Visual implementation #27

Visual implementation #27

Conversation

johanos1 commented Oct 23, 2022 • edited Loading

Description

Resolved Issues

How Has This Been Tested?

Related Pull Requests

gomezzz left a comment

Choose a reason for hiding this comment

gomezzz commented Oct 24, 2022

gomezzz commented Oct 25, 2022

gomezzz left a comment

Choose a reason for hiding this comment

gomezzz left a comment

Choose a reason for hiding this comment

Good news:

Bad news:

gomezzz Oct 31, 2022

Choose a reason for hiding this comment

gomezzz commented Nov 1, 2022

review-notebook-app bot commented Nov 16, 2022

gomezzz left a comment

Choose a reason for hiding this comment

gomezzz Nov 18, 2022

Choose a reason for hiding this comment

gomezzz Nov 18, 2022

Choose a reason for hiding this comment

gomezzz commented Nov 18, 2022

gomezzz left a comment

Choose a reason for hiding this comment

johanos1 commented Oct 23, 2022 •

edited

Loading