Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete flag in the latest version of Dear Imgui #192

Closed
lesauxvi opened this issue Jul 22, 2024 · 3 comments
Closed

Obsolete flag in the latest version of Dear Imgui #192

lesauxvi opened this issue Jul 22, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@lesauxvi
Copy link

Hello,

I wanted to integrate the lastest dear imgui docking branch (1.91 WIP) in my app to test the new multi-select feature that has just been relseased, and I had a compilation issue. It appears that the flag ImGuiItemFlags_SelectableDontClosePopup has been removed in the work-in-progress branch. The flag was still present in the 1.90.9 branch.

See line 878 of imgui_internals.h

// Obsolete
//ImGuiItemFlags_SelectableDontClosePopup = !ImGuiItemFlags_AutoClosePopups, // Can't have a redirect as we inverted the behavior

The flag is used only once in at line 3646 of the file ImGuiFileDialo.cpp. The fix should be pretty straighforward.

@aiekick
Copy link
Owner

aiekick commented Jul 22, 2024

Hello,

arf. ok i is easy to fix.

he is used in the function m_FlashableSelectable who is a copy past of ImGui::Selectable code just a for have a custom var at line 3624 :

    //////////////////////////////////////////////////////////////////
    // this function copy ImGui::Selectable just for this line....
    hovered |= vFlashing;
    //////////////////////////////////////////////////////////////////

i not found another way for have the ability to flash on demand a selectable.

so you can just update the code of m_FlashableSelectable and insert again my code at the good location.

ps : maybe we can ask to ocornut for see if there is now a way for this without copy / past the code of the selectable in IGFD

@aiekick aiekick added the bug Something isn't working label Jul 22, 2024
@aiekick
Copy link
Owner

aiekick commented Jul 22, 2024

fixed

@aiekick aiekick closed this as completed Jul 22, 2024
@lesauxvi
Copy link
Author

Thanks for your reactivity!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants