Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated deprecated resources #3114

Merged

Conversation

@sphuber
Copy link
Contributor

commented Jul 2, 2019

Fixes #2760

All resources that have been deprecated before the release of v1.0.0b1
have been removed. The remaining deprecations are updated to ensure they
use the custom AiidaDeprecationWarning to prevent them from being
filtered by default, as well as that the docstring reflects when the
deprecation resources will be removed.

@sphuber sphuber requested a review from giovannipizzi Jul 2, 2019
@sphuber sphuber force-pushed the sphuber:fix_2760_remove_deprecated_resources branch from b39ac61 to ff4f1ff Jul 2, 2019
@coveralls

This comment has been minimized.

Copy link

commented Jul 2, 2019

Coverage Status

Coverage increased (+0.2%) to 74.34% when pulling cafc64d on sphuber:fix_2760_remove_deprecated_resources into 4738116 on aiidateam:develop.

@sphuber sphuber force-pushed the sphuber:fix_2760_remove_deprecated_resources branch 2 times, most recently from 37f1047 to e8efb2d Jul 2, 2019
@giovannipizzi

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

I think you are missing the removal of the deprecated relationship in the table in the docs of the QueryBuilder, see e.g. here.

@sphuber

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

I think you are missing the removal of the deprecated relationship in the table in the docs of the QueryBuilder, see e.g. here.

Thanks, I removed the column

All resources that have been deprecated before the release of `v1.0.0b1`
have been removed. The remaining deprecations are updated to ensure they
use the custom `AiidaDeprecationWarning` to prevent them from being
filtered by default, as well as that the docstring reflects when the
deprecation resources will be removed.
@sphuber sphuber force-pushed the sphuber:fix_2760_remove_deprecated_resources branch from e8efb2d to cafc64d Jul 2, 2019
@sphuber sphuber merged commit 406dbb4 into aiidateam:develop Jul 2, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 74.34%
Details
@sphuber sphuber deleted the sphuber:fix_2760_remove_deprecated_resources branch Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.